Skip to content

merge terraform.yaml#7463

Merged
c2thorn merged 2 commits into
GoogleCloudPlatform:mainfrom
c2thorn:merge-terraform.yaml
Mar 16, 2023
Merged

merge terraform.yaml#7463
c2thorn merged 2 commits into
GoogleCloudPlatform:mainfrom
c2thorn:merge-terraform.yaml

Conversation

@c2thorn
Copy link
Copy Markdown
Member

@c2thorn c2thorn commented Mar 15, 2023

removes terraform.yaml files. Override functionality still exists and will be stripped away later.
Existing diffs should be description/documentation related only.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@c2thorn c2thorn requested a review from a team as a code owner March 15, 2023 22:35
@c2thorn c2thorn requested review from slevenick and removed request for a team and slevenick March 15, 2023 22:35
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 2 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 12 files changed, 2 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 12 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 1 file changed, 9 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn c2thorn requested a review from rileykarson March 16, 2023 16:46
Copy link
Copy Markdown
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked through this earlier since I was curious and looked good then- LGTM

(plus there's no diffs anyways)

@c2thorn c2thorn force-pushed the merge-terraform.yaml branch from 3daf2d9 to 900796d Compare March 16, 2023 16:51
@c2thorn
Copy link
Copy Markdown
Member Author

c2thorn commented Mar 16, 2023

Poked through this earlier since I was curious and looked good then- LGTM

(plus there's no diffs anyways)

thanks! I just repackaged this into two separate commits by change type if you are interested. Plan to merge this afternoon after announcing to other maintainers

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2501
Passed tests 2236
Skipped tests: 263
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@c2thorn c2thorn force-pushed the merge-terraform.yaml branch from 900796d to 97a67a4 Compare March 16, 2023 21:38
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants