merge terraform.yaml#7463
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 12 files changed, 2 insertions(+), 14 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. TF Validator: Diff ( 1 file changed, 9 insertions(+), 9 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
rileykarson
left a comment
There was a problem hiding this comment.
Poked through this earlier since I was curious and looked good then- LGTM
(plus there's no diffs anyways)
3daf2d9 to
900796d
Compare
thanks! I just repackaged this into two separate commits by change type if you are interested. Plan to merge this afternoon after announcing to other maintainers |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceDnsManagedZone_basic |
|
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
900796d to
97a67a4
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
removes
terraform.yamlfiles. Override functionality still exists and will be stripped away later.Existing diffs should be description/documentation related only.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)