Skip to content

docs: Updated argument descriptions in apigee_addons_config resource to match with corresponding REST API specs.#7405

Merged
trodge merged 4 commits into
GoogleCloudPlatform:mainfrom
ronsonx:main
May 20, 2025
Merged

docs: Updated argument descriptions in apigee_addons_config resource to match with corresponding REST API specs.#7405
trodge merged 4 commits into
GoogleCloudPlatform:mainfrom
ronsonx:main

Conversation

@ronsonx

@ronsonx ronsonx commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

docs: Updated argument descriptions in apigee_addons_config resource to match with corresponding REST API specs.

There were incorrect descriptions for some arguments. Updated them to match with the published API specification.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Updated argument descriptions in apigee_addons_config resource to match with corresponding REST API specs.

…to match with corresponding REST API specs.
@ronsonx ronsonx requested a review from a team as a code owner March 6, 2023 08:03
@ronsonx ronsonx requested review from trodge and removed request for a team March 6, 2023 08:03
@trodge

trodge commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

/gcbrun

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 20 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 2 files changed, 20 insertions(+), 20 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2499
Passed tests 2163
Skipped tests: 262
Affected tests: 74

Action taken

Found 74 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeSharedVpc_basic|TestAccIAM2AccessBoundaryPolicy|TestAccKmsKeyRing_basic|TestAccComputeResourceUsageExportBucket|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccLoggingBucketConfigProject_cmekSettings|TestAccKmsKeyRingIamPolicy|TestAccIAM2DenyPolicy_iamDenyPolicyUpdate|TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccKmsKeyRingIamPolicy_withCondition|TestAccProject_deleteDefaultNetwork|TestAccKmsKeyRingIamMember_withCondition|TestAccKmsKeyRingIamMember|TestAccKmsKeyRingIamBinding_withCondition|TestAccDialogflowIntent_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccKmsKeyRingIamBinding|TestAccDialogflowIntent_update|TestAccKmsCryptoKeyVersion_patch|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccDialogflowFulfillment_update|TestAccKmsCryptoKeyVersion_basic|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccDialogflowEntityType_update|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKeyIamMember|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKeyIamBinding|TestAccDialogflowAgent_update|TestAccComputeProjectMetadata_basic|TestAccComputeProjectMetadata_modify_1|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeProjectDefaultNetworkTier_basic|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeForwardingRule_update|TestAccBinaryAuthorizationPolicy_update|TestAccBinaryAuthorizationPolicy_separateProject|TestAccBinaryAuthorizationPolicy_full|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccBinaryAuthorizationPolicy_basic|TestAccAppEngineStandardAppVersion_update|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeSyncAuthorization_update|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccLoggingProjectCmekSettings_basic|TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccComputeSharedVpc_basic[Debug log]
TestAccIAM2AccessBoundaryPolicy[Debug log]
TestAccKmsKeyRing_basic[Debug log]
TestAccComputeResourceUsageExportBucket[Debug log]
TestAccLoggingBucketConfig_CreateBuckets_withCustomId[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccKmsKeyRingIamPolicy[Debug log]
TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample[Debug log]
TestAccOsConfigOsPolicyAssignment_basicOsPolicyAssignment[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDelete[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDisable[Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsBasic[Debug log]
TestAccKmsKeyRingIamPolicy_withCondition[Debug log]
TestAccProject_deleteDefaultNetwork[Debug log]
TestAccKmsKeyRingIamMember_withCondition[Debug log]
TestAccKmsKeyRingIamMember[Debug log]
TestAccKmsKeyRingIamBinding_withCondition[Debug log]
TestAccDialogflowIntent_basic[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccKmsKeyRingIamBinding[Debug log]
TestAccDialogflowIntent_update[Debug log]
TestAccKmsCryptoKeyVersion_patch[Debug log]
TestAccKmsCryptoKeyVersion_skipInitialVersion[Debug log]
TestAccDialogflowFulfillment_update[Debug log]
TestAccKmsCryptoKeyVersion_basic[Debug log]
TestAccKmsCryptoKey_destroyDuration[Debug log]
TestAccKmsCryptoKey_template[Debug log]
TestAccKmsCryptoKey_basic[Debug log]
TestAccKmsCryptoKeyIamPolicy_withCondition[Debug log]
TestAccDialogflowEntityType_update[Debug log]
TestAccKmsCryptoKeyIamPolicy[Debug log]
TestAccKmsCryptoKeyIamMember_withCondition[Debug log]
TestAccKmsCryptoKey_importOnly[Debug log]
TestAccKmsCryptoKeyIamMember[Debug log]
TestAccKmsCryptoKeyIamBinding_withCondition[Debug log]
TestAccKmsCryptoKeyIamBinding[Debug log]
TestAccDialogflowAgent_update[Debug log]
TestAccComputeProjectMetadata_basic[Debug log]
TestAccComputeProjectMetadata_modify_1[Debug log]
TestAccComputeProjectMetadata_modify_2[Debug log]
TestAccComputeProjectDefaultNetworkTier_modify[Debug log]
TestAccComputeProjectDefaultNetworkTier_basic[Debug log]
TestAccComputeInstanceFromMachineImage_diffProject[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBinaryAuthorizationPolicy_update[Debug log]
TestAccBinaryAuthorizationPolicy_separateProject[Debug log]
TestAccBinaryAuthorizationPolicy_full[Debug log]
TestAccAssuredWorkloadsWorkload_FullHandWritten[Debug log]
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Debug log]
TestAccAssuredWorkloadsWorkload_BasicHandWritten[Debug log]
TestAccBinaryAuthorizationPolicy_basic[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApigeeSyncAuthorization_update[Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Debug log]
TestAccLoggingProjectCmekSettings_basic[Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccIAM2DenyPolicy_iamDenyPolicyUpdate[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge trodge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronsonx

ronsonx commented Mar 17, 2023

Copy link
Copy Markdown
Contributor Author

Resolved conflicts from #7463

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jun 5, 2024

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 7 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 8 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jul 3, 2024

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 9 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 10 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 11 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 12 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 13 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Aug 7, 2024

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 14 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 15 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 16 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 17 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 18 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions Bot requested a review from trodge September 6, 2024 19:55
@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 25 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Mar 7, 2025

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 26 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 27 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 28 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 29 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 30 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 31 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 32 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 33 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 34 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 35 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

This PR is approved and has been waiting for merge for 36 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions Bot requested a review from trodge May 20, 2025 21:43
@trodge trodge enabled auto-merge May 20, 2025 21:43
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 20, 2025
@trodge trodge added this pull request to the merge queue May 20, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 503e327 May 20, 2025
17 of 18 checks passed
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
…to match with corresponding REST API specs. (GoogleCloudPlatform#7405)

Co-authored-by: Ronson Xaviour <ronson.xaviour@intelliswift.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/apigee

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants