Skip to content

go rewrite - compute documentation diffs#11021

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
c2thorn:rewrite-compute
Jun 25, 2024
Merged

go rewrite - compute documentation diffs#11021
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
c2thorn:rewrite-compute

Conversation

@c2thorn

@c2thorn c2thorn commented Jun 24, 2024

Copy link
Copy Markdown
Member

pending #11020

we've been able to work through Ruby MMv1's lines function by manipulating whitespace up until now. Recursively calls of lines within nested documentation leads to hard-to-replicate diffs, so this PR attempts to replicate the logic with a throwaway TrimTemplate function

diff generated from this PR : c2thorn/terraform-provider-google-beta@39f4444

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 30 deletions(-))
google-beta provider: Diff ( 18 files changed, 30 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 30 deletions(-))
google-beta provider: Diff ( 18 files changed, 30 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1781
Passed tests: 890
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

1 similar comment
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1781
Passed tests: 890
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn c2thorn requested a review from zli82016 June 25, 2024 16:31

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants