Skip to content

go rewrite - description-copy update and overall refresh#11020

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
c2thorn:rewrite-refresh
Jun 24, 2024
Merged

go rewrite - description-copy update and overall refresh#11020
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
c2thorn:rewrite-refresh

Conversation

@c2thorn

@c2thorn c2thorn commented Jun 24, 2024

Copy link
Copy Markdown
Member

adds the following identifiers to description-copy.go

  • "warning:",
  • "required_properties:",
  • "optional_properties:",
  • "attributes:",

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 30 deletions(-))
google-beta provider: Diff ( 18 files changed, 30 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1781
Passed tests: 890
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 30 deletions(-))
google-beta provider: Diff ( 18 files changed, 30 deletions(-))

@c2thorn c2thorn requested a review from NickElliot June 24, 2024 13:56
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1781
Passed tests: 890
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its nice how universally this copy script is working

@c2thorn

c2thorn commented Jun 24, 2024

Copy link
Copy Markdown
Member Author

its nice how universally this copy script is working

it's not perfect, but it's at the point where it's just easier to edit the outlier ruby YAML files instead of the script 😁

@c2thorn c2thorn merged commit def52fe into GoogleCloudPlatform:main Jun 24, 2024
@c2thorn c2thorn deleted the rewrite-refresh branch June 24, 2024 16:14
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 24, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
vijaykanthm pushed a commit to vijaykanthm/magic-modules that referenced this pull request Jul 22, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants