Skip to content

update datagovtheme to remove topic facet #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FuhuXia merged 3 commits into from
Sep 24, 2025
Merged

update datagovtheme to remove topic facet #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c085751
update datagovtheme to remove topic facet
FuhuXia Sep 19, 2025
4db0953
update test
FuhuXia Sep 19, 2025
267b14c
update test
FuhuXia Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ckan/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ chardet==5.2.0
charset-normalizer==3.4.3
ckan @ git+https://github.com/GSA/ckan.git@416b88e74d2bd643bcdd1da7a900e29c6d443bfe
-e git+https://github.com/GSA/ckanext-datagovcatalog.git@b60f69e4cb15d3cdce80698e5b4b2dc406a2ca05#egg=ckanext_datagovcatalog
ckanext-datagovtheme==0.4.3
ckanext-datagovtheme==0.4.4
ckanext-datajson==0.1.28
ckanext-dcat @ git+https://github.com/ckan/ckanext-dcat@255fcf1352273f9be98e9f02a5198efc4790c94e
ckanext-envvars==0.0.6
Expand Down
8 changes: 4 additions & 4 deletions e2e/cypress/integration/facets.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@ describe('Facets', { testIsolation: false }, () => {

it('Show datagov facet list on dataset page', () => {
cy.visit('/dataset');
cy.get('.filters h2').its('length').should('be.equal', 9);
cy.get('.filters h2').first().contains('Topics');
cy.get('.filters h2').its('length').should('be.equal', 7);
cy.get('.filters h2').first().contains('Dataset Type');
cy.get('.filters h2').last().contains('Bureaus');
});

it('Show datagov facet list on organization page', () => {
cy.visit('/organization');
cy.get('a[class="btn btn-primary"]').click();
cy.visit('/organization/' + orgName);
cy.get('.module-shallow').its('length').should('be.equal', 10);
cy.get('.module-shallow').contains('Topics');
cy.get('.module-shallow').its('length').should('be.equal', 7);
cy.get('.module-shallow').contains('Dataset Type');
cy.get('.module-shallow').contains('Harvest Source');
cy.get('.module-shallow').last().contains('Bureaus');
});
Expand Down
Loading