update datagovtheme to remove topic facet #1731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrown-xentity
previously approved these changes
Sep 19, 2025
Contributor
jbrown-xentity
left a comment
There was a problem hiding this comment.
LGTM, changes reviewed and approved in source repo.
Member
Author
|
verified on development space |
Contributor
|
@FuhuXia sorry, looks like there's still some tests that need updating from this change... https://github.com/GSA/catalog.data.gov/actions/runs/17867467740/job/50813179481?pr=1731#step:4:1018 Once that is fixed, happy to do a quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing changes from GSA/ckanext-datagovtheme#243.