Skip to content

Comments

#1253 Disable password-protected messages when FES is not used#1342

Merged
tomholub merged 7 commits intomasterfrom
feature/issue-1253-only-fes-password
Feb 2, 2022
Merged

#1253 Disable password-protected messages when FES is not used#1342
tomholub merged 7 commits intomasterfrom
feature/issue-1253-only-fes-password

Conversation

@sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Jan 27, 2022

This PR enables password-protected messages only when FES is used

close #1253


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky marked this pull request as ready for review January 28, 2022 09:27
@sosnovsky sosnovsky requested a review from tomholub January 28, 2022 09:27
@sosnovsky
Copy link
Collaborator Author

I think that after finishing and merging #1331 we should also update EnterpriseServerApi to have email property (which will be passed from AppContextWithUser), so we don't need to pass it manually for every method.
Then we'll be able to fetch fesUrl only once and store result locally, while currently it's fetched for each request.

@sosnovsky
Copy link
Collaborator Author

@tomholub I have 2 remaining tasks - #1327 from 0.8.0 milestone and #1120 from 0.9.0
Should I also take some other tasks from 0.8.0 like #953 or #954 ?

@tomholub tomholub merged commit 12565d2 into master Feb 2, 2022
@tomholub tomholub deleted the feature/issue-1253-only-fes-password branch February 2, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disable password-protected messages if FES is not used

2 participants