Skip to content

Comments

Current user should be dependency-injected#1331

Merged
sosnovsky merged 11 commits intomasterfrom
feature/issue-863
Feb 1, 2022
Merged

Current user should be dependency-injected#1331
sosnovsky merged 11 commits intomasterfrom
feature/issue-863

Conversation

@ivan-ushakov
Copy link
Contributor

close #863


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ivan-ushakov ivan-ushakov marked this pull request as draft January 24, 2022 19:20
@ivan-ushakov ivan-ushakov marked this pull request as ready for review January 25, 2022 18:53
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it doesn't look bad to me. See comments.

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✅

@sosnovsky sosnovsky merged commit 67d30b1 into master Feb 1, 2022
@sosnovsky sosnovsky deleted the feature/issue-863 branch February 1, 2022 22:41
@sosnovsky sosnovsky mentioned this pull request Feb 9, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

current user should be dependency-injected

3 participants