prepwork for working with x509 private keys#3216
Merged
Conversation
tomholub
reviewed
Dec 4, 2020
tomholub
reviewed
Dec 8, 2020
wiktor-k
commented
Dec 8, 2020
added 4 commits
March 27, 2021 09:38
tomholub
approved these changes
Mar 27, 2021
Collaborator
|
I've cleaned it up and created followup issues so that this PR doesn't keep collecting dust and merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR to get the CI results (some tests fail for me locally). It'll be improved with time :)
// edit tom: originally this was addressing issue #2969 but it wasn't finished. I created various other issues to address the delta between the original issue and this PR: #3527 #3528 #3529 #3530