show pass phrase field before parsing private key

[tomholub]

This logic here needs to be inverted. That is node-forge requires good password but when clicking on "import file" we don't have the password field shown yet.

I think we need to do only small level of sanity checks for X.509 keys here as it seems that's what the function is doing here (reads the key and immediately armors it discarding the object) and then do the full parse in checkPrv.

Originally posted by @wiktor-k in #3216 (comment)

[tomholub]

Right now, in KeyImportUI (setup or add additional key) we first load and parse the key, and then render pass phrase input after.

This is not compatible with pkcs12 formatted s/mime x509 keys because these cannot be parsed without pass phrase.

Therefore we should render pass phrase input earlier, so that pass phrase is available when we do the parsing.

[tomholub]

Together with that, we could also change this:

        for (const key of keys) {
          // we should decrypt them all here to have consistent behavior between pkcs12 files and PGP
          // pkcs12 files must be decrypted during parsing
          // then rename this method to parseDecryptBinary
          const parsed = await OpenPGPKey.convertExternalLibraryObjToKey(key);
          // if (await KeyUtil.decrypt(parsed, passPhrase, undefined, 'OK-IF-ALREADY-DECRYPTED')) {
          allKeys.push(parsed);
          // } else {
          //   allErr.push(new Error(`Wrong pass phrase for OpenPGP key ${parsed.id} (${parsed.emails[0]})`));
          // }
        }

[tomholub]

I suppose this will no longer be relevant after #3938 / #3530