Skip to content

Comments

issue #955 improve backup status#2518

Merged
tomholub merged 10 commits intomasterfrom
issue-955-improve-backup-check
Feb 1, 2020
Merged

issue #955 improve backup status#2518
tomholub merged 10 commits intomasterfrom
issue-955-improve-backup-check

Conversation

@tomholub
Copy link
Collaborator

@tomholub tomholub commented Feb 1, 2020

close #955

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

These could possibly be removed:

$('#module_manual .action_skip_backup').click(this.view.setHandler(el => this.actionSkipBackupHandler()));
  private actionSkipBackupHandler = async () => {
    if (this.view.action === 'setup') {
      await Store.setAcct(this.view.acctEmail, { key_backup_prompt: false });
      window.location.href = Url.create('/chrome/settings/setup.htm', { acctEmail: this.view.acctEmail });
    } else {
      if (this.view.parentTabId) {
        BrowserMsg.send.closePage(this.view.parentTabId);
      } else {
        Catch.report(`backup.ts: missing parentTabId for ${this.view.action}`);
      }
    }
  }

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

Figure out difference between setup eg

    <div id="step_2a_manual_create" class="manual">
      <div class="line left">Choose pass phrase to protect your encrypted emails. <a href="#"
          data-featherlight="/chrome/texts/passphrase_help.htm">choosing
          secure pass phrases</a></div>
      <div class="line left">
        <input class="input_password" type="text" placeholder="Pass phrase" style="margin-bottom: 0;"
          id="step_2a_manual_create_input_password" data-test="input-step2bmanualcreate-passphrase-1" />
      </div>
      <div class="line left">
        <input class="input_pass_phrase_confirm" type="text" placeholder="Repeat pass phrase"
          id="step_2a_manual_create_input_pass_phrase_confirm" data-test="input-step2bmanualcreate-passphrase-2" />
      </div>

vs what is in backup.ts

    <div id="module_setup_2_confirm_pp">
      <div class="line">Please repeat it one more time. Make sure to note the pass phrase down.</div>
      <div class="line">
        <input id="pass_phrase_confirm" type="text" placeholder="Repeat pass phrase" />
      </div>
      <div class="line">
        <button class="button long green action_backup">CONFIRM PASS PHRASE</button>
      </div>
      <div class="line">
        <button class="button long gray action_reset_password">USE ANOTHER PASS PHRASE</button>
      </div>
    </div>

In case it can be united

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

  • action_proceed_default_backup_choice can probably be removed
  • anything related to entering pass phrase can be removed, can send user to change their pass phrase in change_passphrase.htm

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

BackupChangePpModule could be thrown away, instead show manual?

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

delete options action, let the default be that

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

delete setup_simple

@tomholub
Copy link
Collaborator Author

tomholub commented Feb 1, 2020

consider removing key_backup_method

@tomholub tomholub merged commit 5284d7e into master Feb 1, 2020
@tomholub tomholub deleted the issue-955-improve-backup-check branch February 6, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve backup status screen for multiple keys

1 participant