Skip to content

Add ext- requirements to composer.json#76

Merged
matthewelwell merged 6 commits intoFlagsmith:mainfrom
misakstvanu:ext-requirements
Sep 10, 2024
Merged

Add ext- requirements to composer.json#76
matthewelwell merged 6 commits intoFlagsmith:mainfrom
misakstvanu:ext-requirements

Conversation

@misakstvanu
Copy link
Contributor

Having extensions listed in documentation is cool, having them in composer is even cooler. Added bcmath, gmp, json to composer.json.

composer.json Outdated
"php": ">=7.4",
"ext-bcmath": "*",
"ext-gmp": "*",
"ext-json": "*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does JSON need adding here since it wasn't in the original documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package uses json_encode and json_decode, so I added it also.
That said, since PHP8.0, json extension is always installed and it is not really necessary since.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, yeah. In fact, I just removed PHP7 from the test matrix here, so I think we can probably remove JSON from this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, sorry about that.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misakstvanu can you fix the conflicts and I can get this merged?

@misakstvanu
Copy link
Contributor Author

Done

@VincentLanglet
Copy link
Contributor

Hi @matthewelwell,

There is something weird with the "4.5.0 release" with this PR.
The tag is available here: https://github.com/Flagsmith/flagsmith-php-client/releases/tag/v4.5.0
But not on packagist https://packagist.org/packages/flagsmith/flagsmith-php-client

So we cannot install the 4.5.0 version of flagsmith.

@matthewelwell
Copy link
Contributor

Sorry @VincentLanglet , I believe that's because we hadn't updated the version number in composer.json 🤦

I have a PR open to do that now (here), and I will recreate the tag as soon as I can. Apologies.

@matthewelwell
Copy link
Contributor

@VincentLanglet this is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants