Add ext- requirements to composer.json#76
Conversation
composer.json
Outdated
| "php": ">=7.4", | ||
| "ext-bcmath": "*", | ||
| "ext-gmp": "*", | ||
| "ext-json": "*", |
There was a problem hiding this comment.
Does JSON need adding here since it wasn't in the original documentation?
There was a problem hiding this comment.
The package uses json_encode and json_decode, so I added it also.
That said, since PHP8.0, json extension is always installed and it is not really necessary since.
There was a problem hiding this comment.
Ah, ok, yeah. In fact, I just removed PHP7 from the test matrix here, so I think we can probably remove JSON from this list.
There was a problem hiding this comment.
Fair, sorry about that.
matthewelwell
left a comment
There was a problem hiding this comment.
@misakstvanu can you fix the conflicts and I can get this merged?
|
Done |
|
Hi @matthewelwell, There is something weird with the "4.5.0 release" with this PR. So we cannot install the |
|
Sorry @VincentLanglet , I believe that's because we hadn't updated the version number in composer.json 🤦 I have a PR open to do that now (here), and I will recreate the tag as soon as I can. Apologies. |
|
@VincentLanglet this is now resolved. |
Having extensions listed in documentation is cool, having them in composer is even cooler. Added bcmath, gmp, json to composer.json.