Skip to content

Fix <emoji> is mistaken as <em> - #760

Merged
cristipaval merged 1 commit into
Expensify:mainfrom
gijoe0295:gijoe/45635
Jul 26, 2024
Merged

Fix <emoji> is mistaken as <em>#760
cristipaval merged 1 commit into
Expensify:mainfrom
gijoe0295:gijoe/45635

Conversation

@gijoe0295

@gijoe0295 gijoe0295 commented Jul 22, 2024

Copy link
Copy Markdown

Fixed Issues

$ Expensify/App#45635
$ PROPOSAL: Expensify/App#45635 (comment)

Tests

  1. Send this message:
~👿~ _abc_
  1. Edit the message
  2. Verify the message in edit composer matches the original message in step 1
  3. Open workspace room
  4. Change room description to the message in step 1 and save
  5. Open room description page again
  6. Verify the room description matches the original description in step 1

Screenshots/Videos

Android: Native

Screenshot_1721871271

Android: mWeb Chrome

Screenshot_1721871353

iOS: Native
iOS: mWeb Safari

simulator_screenshot_BD4A70AE-D1FA-43FA-BA23-BD5044CA7E90

MacOS: Chrome / Safari

Screenshot 2024-07-25 at 08 32 54

Screenshot 2024-07-25 at 08 42 30

MacOS: Desktop

Screenshot 2024-07-25 at 08 37 08

@github-actions

github-actions Bot commented Jul 22, 2024

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gijoe0295

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@gijoe0295
gijoe0295 marked this pull request as ready for review July 25, 2024 01:37
@gijoe0295
gijoe0295 requested a review from a team as a code owner July 25, 2024 01:37
@gijoe0295 gijoe0295 changed the title [WIP] Fix <emoji> is mistaken as <em> Fix <emoji> is mistaken as <em> Jul 25, 2024
@melvin-bot
melvin-bot Bot requested review from neil-marcellini and removed request for a team July 25, 2024 01:38
@gijoe0295

Copy link
Copy Markdown
Author

@parasharrajat This one can be review now.

@parasharrajat

Copy link
Copy Markdown
Member

@neil-marcellini Please trigger workflows

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🎀 👀 🎀 C+ reviewed

@neil-marcellini neil-marcellini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks! @cristipaval is managing the issue so I'll request his review too.

@cristipaval
cristipaval merged commit 4cc5e30 into Expensify:main Jul 26, 2024
@github-actions

Copy link
Copy Markdown

🚀Published to npm in v2.0.56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants