[HOLD for payment 2024-08-07] [$250] Android - Workspace - WS description with markdown is not shown correctly on opening preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4697842
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap profile icon -- Workspaces -- workspace
3. Tap description
4. Enter fhjj 57
5. Tap Save
6. Tap description again and note markdown shown as it was entered
7. Now change markdown as 😃 57
8. Tap save
9. Tap description again and note markdown

Expected Result:

Workspace description should be shown as 😃 57

Actual Result:

Workspace description should be shown as 😃 57 but displayed as _😃 57_

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6545580_1721244119403.Screenrecorder-2024-07-18-00-40-34-372_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183f826d1418b3bc1
• Upwork Job ID: 1815267370451723401
• Last Price Increase: 2024-07-22
• Automatic offers:
• gijoe0295 | Contributor | 103221829

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace description should be shown as 😃 57 but displayed as 😃 57

What is the root cause of that problem?

Current: Input: <del><emoji>👿</emoji></del> <em>abc</em>. Output: ~_👿</emoji>~ abc_.

We see that the opening <emoji> tag is mistaken as <em>.

Let's take a look at the parsing regex taken from here:

/<(em|i)(?:"[^"]*"|'[^']*'|[^'">])*>([\s\S]*?)<\/\1>(?![^<]*(<\/pre>|<\/code>))/gi

• <(em|i) is the opening tag (i.e. <em or <i)
• (?:"[^"]*"|'[^']*'|[^'">])* is any other attributes within the opening tag where the [^'">] accounts for all characters except ^, ', " and >
• > is the closed bracket of the opening tag
• <\/\1> is the closing tag group

So obviously the problem is with the second group above where it covers all the cases where the tag name starts with either em or i as long as the closing tag is </em> or </i>, for example:

<emoji>abc</em>
<img>xyz</i>

What changes do you think we should make in order to solve the problem?

The regex \bcat\b would therefore match cat in a black cat, but it wouldn't match it in catatonic, tomcat or certificate. Removing one of the boundaries, \bcat would match cat in catfish, and cat\b would match cat in tomcat, but not vice-versa.

Reference: https://www.rexegg.com/regex-boundaries.php#wordboundary

We should append word boundary to the tag names em and i:

<(em|i)\b

We don't need to prepend \b because they are already prepended with <.

We see that this issue can happens with any other tags, we should apply word boundary for them as well.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183f826d1418b3bc1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)