Migrate workspace per diem page to the new Table component by Krishna2323 · Pull Request #94912 · Expensify/App

Krishna2323 · 2026-06-29T22:14:37Z

Explanation of Change

Fixed Issues

$ #86209
PROPOSAL:

Tests

Setup

Use a workspace with Per Diem enabled and admin/control access. Ideally test with:

A workspace with 0 per diem rates (empty)
A workspace with 1–11 rates (no search bar)
A workspace with 12+ rates (search bar visible)

Web – wide layout

Open Workspace → Per Diem.
Confirm the page title is Per Diem, the subtitle HTML renders above the table, and columns are Destination, Subrate, and Amount.
Click a row and confirm navigation to the per diem details screen.
Click each column header (Destination, Subrate, Amount) and confirm rows sort correctly; toggle asc/desc and confirm order updates.
When two rows share the same primary sort value, confirm tie-break sorting is stable (e.g. same destination → sorted by subrate).
Select one or more rows via the row checkboxes and confirm the header shows Selected (N) with a Delete bulk action.
Delete selected rates, confirm the modal, and verify rates are removed and selection clears.
Open More and verify Import spreadsheet, Download CSV, and Settings (if categories are enabled) still work.

Web – narrow layout (resize browser or use narrow pane)

Repeat steps 1–4 and confirm the table uses the compact row layout (destination on top, subrate + amount below).
Long-press a row (or use the table’s mobile selection entry) to enter selection mode and confirm the header title changes to Select multiple.
Tap rows to toggle selection and confirm the bulk Delete action appears.
Press browser/device Back while in selection mode and confirm selection clears and selection mode exits.

Search (12+ rates required)

Confirm the Find per diem rate search bar appears only when there are 12 or more rates.
Search by destination and confirm matching rows appear.
Search by subrate name and confirm matching rows appear.
Enter a query with no matches and confirm a No results found message appears (table header/search remain visible).

Empty & loading states

On a workspace with no per diem rates, confirm the subtitle still shows, the empty state appears with Import spreadsheet, and import navigates correctly.
On a workspace with rates, refresh/reopen the page and confirm a loading spinner appears with the subtitle; after load, the table renders normally.

Bulk delete & selection cleanup

Select several rates and delete them all; confirm selection clears and you exit mobile selection mode (narrow layout).
Select rates, then press the header Back button; confirm selection clears and selection mode exits without deleting.
Select rates, clear the search filter (if active), and confirm selected items are not dropped from the selection count.

`backTo` navigation (expense flow)

Start creating a Per Diem expense and navigate to Workspace → Per Diem from that flow (e.g. destination picker linking to workspace rates).
Press Back and confirm you return to the expense creation screen, not an unrelated page.

Read-only / non-admin member (if available)

Log in as a member without per diem write access and open Per Diem.
Confirm rows are visible and tappable for details, but no checkboxes, no bulk delete, and no long-press selection appear.

Native (iOS / Android) – additional checks

Repeat steps 9–12 on a physical device or simulator.
Press the hardware/gesture back button while in selection mode and confirm selection clears and the page navigates back correctly.
Scroll the table and confirm rows, header, and search bar scroll/perform smoothly with no layout clipping.

Verify that no errors appear in the JS console

Offline tests

Go offline, open Per Diem, and confirm existing rates still display.
While offline, open More → Import spreadsheet or Download CSV and confirm the offline modal appears.

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-06-29T22:58:59Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11b45a1c9a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-06-29T23:05:26Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.02% <ø> (ø)`
...WorkspacePerDiemTable/WorkspacePerDiemTableRow.tsx	`0.00% <0.00%> (ø)`
...c/pages/workspace/perDiem/WorkspacePerDiemPage.tsx	`0.00% <0.00%> (ø)`
.../components/Tables/WorkspacePerDiemTable/index.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-06-29T23:15:59Z

@codex review

chatgpt-codex-connector · 2026-06-29T23:21:35Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 69d1a6384b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-06-30T00:05:12Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…86209

Krishna2323 · 2026-06-30T00:18:01Z

The failing test isn't related.

situchan · 2026-06-30T13:56:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

chatgpt-codex-connector · 2026-06-30T14:01:59Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 1237008d9d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…86209

luacmartins

LGTM

luacmartins · 2026-06-30T18:29:54Z

@JS00001 is OOO, so I'll merge

github-actions · 2026-06-30T18:35:40Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-30T18:37:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-30T18:42:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94912.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e6307b9877d-6f1f532-4f36d37ea9b6f37ac083b0685edef53199c23b0a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e6307b9-6f1f532-43c372be8880d1bbdb4c92b4a45e99b0d48ca70a/index.html

Web 🕸️
https://94912.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-01T20:14:22Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-01T20:17:52Z

🤖 Help site review: no docs/articles changes required.

This PR migrates the workspace Per Diem page to the new Table component (WorkspacePerDiemTable/index.tsx, WorkspacePerDiemPage.tsx). It's a presentational/component refactor — every documented workflow still behaves the same, so I did not open a draft PR.

I checked the one article that covers this surface, Configure-Per-Diem-in-a-workspace.md, against the diff:

Import spreadsheet / Download CSV (three‑dot / More menu) — unchanged.
Edit / delete rates, incl. selecting rows and bulk delete — unchanged.
Settings → Default category — unchanged.

The only new, undocumented behaviors are generic to the shared table — sortable Destination / Subrate / Amount columns and a Find per diem rate search bar that appears at 12+ rates. These aren't workflow changes and the current article doesn't document table mechanics, so I don't think they warrant a doc update. If you'd like the article to call out sorting/search, let me know and I'll draft it.

@Krishna2323, since no help site PR was needed, there's nothing to link or mark Ready for review. If you disagree and want doc updates, reply with @MelvinBot <what to document> and I'll create the draft PR.

jponikarchuk · 2026-07-01T21:28:16Z

Deploy Blocker #95092 was identified to be related to this PR.

jponikarchuk · 2026-07-02T05:31:12Z

This PR failing because of the issue #95118
This issue is reproducible in: Web

jponikarchuk · 2026-07-02T07:00:29Z

This PR failing because of the issue #95128
This issue is reproducible in: All platforms

OSBotify · 2026-07-06T15:32:18Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Migrate workspace per diem page to the new Table component

bf1c5de

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 Jun 29, 2026

Align per diem table with migrated table conventions

11b45a1

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx Outdated

Use composite keys for per diem table row selection

69d1a63

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review June 30, 2026 00:05

Krishna2323 requested review from a team as code owners June 30, 2026 00:05

melvin-bot Bot requested review from heyjennahay and situchan and removed request for a team June 30, 2026 00:05

Merge branch 'Expensify:main' into krishna2323-update-per-diem-table-…

1237008

…86209

Merge branch 'Expensify:main' into krishna2323-update-per-diem-table-…

63b7e85

…86209

luacmartins self-requested a review June 30, 2026 15:55

luacmartins approved these changes Jun 30, 2026

View reviewed changes

situchan approved these changes Jun 30, 2026

View reviewed changes

melvin-bot Bot requested review from JS00001 and luacmartins June 30, 2026 18:23

luacmartins approved these changes Jun 30, 2026

View reviewed changes

luacmartins merged commit e6307b9 into Expensify:main Jun 30, 2026
34 of 35 checks passed

OSBotify mentioned this pull request Jul 1, 2026

Deploy Checklist: New Expensify 2026-07-01 #95081

Closed

97 tasks

applause-bot Bot mentioned this pull request Jul 1, 2026

[Due for payment 2026-07-13] [$250] Android - Per diem - Missing "Set per diem rates to..." description #95092

Closed

7 tasks

jponikarchuk mentioned this pull request Jul 1, 2026

[Due for payment 2026-07-13] [Update Table Styles] Update the policy per-diem table #86209

Closed

applause-bot Bot mentioned this pull request Jul 2, 2026

[$250] Web-Per diem-Back browser leads to ws settings page instead of exiting selection mode #95118

Closed

7 tasks

applause-bot Bot mentioned this pull request Jul 2, 2026

[$250] Selected rows are not dropped from the selection count after clearing search filter #95128

Closed

7 tasks

MelvinBot mentioned this pull request Jul 2, 2026

[CP Staging] Fix missing per diem subtitle on Android by re-adding flexRow wrapper #95164

Merged

43 tasks

Uh oh!

Conversation

Krishna2323 commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Setup

Web – wide layout

Web – narrow layout (resize browser or use narrow pane)

Search (12+ rates required)

Empty & loading states

Bulk delete & selection cleanup

backTo navigation (expense flow)

Read-only / non-admin member (if available)

Native (iOS / Android) – additional checks

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jun 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 29, 2026

Uh oh!

melvin-bot Bot commented Jun 30, 2026

Uh oh!

Krishna2323 commented Jun 30, 2026

Uh oh!

situchan commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Jun 30, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Jun 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

MelvinBot commented Jul 1, 2026

Uh oh!

jponikarchuk commented Jul 1, 2026

Uh oh!

jponikarchuk commented Jul 2, 2026

Uh oh!

jponikarchuk commented Jul 2, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Krishna2323 commented Jun 29, 2026 •

edited

Loading

`backTo` navigation (expense flow)

codecov Bot commented Jun 29, 2026 •

edited by github-actions Bot

Loading

situchan commented Jun 30, 2026 •

edited

Loading