Skip to content

Revert #92007 Concierge AI Feature Promo Modal#93977

Merged
blimpich merged 1 commit into
mainfrom
revert-pr-92007
Jun 18, 2026
Merged

Revert #92007 Concierge AI Feature Promo Modal#93977
blimpich merged 1 commit into
mainfrom
revert-pr-92007

Conversation

@mjasikowski

@mjasikowski mjasikowski commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This reverts #92007.

The revert removes the AI features promo modal flow, related navigation guard and routes, added animations, and related language/constants updates, restoring the previous behavior from main before that PR was merged.

Fixed Issues

#93964
#93968
#93969
#93970
#93973
#93974
#93976

Tests

  • Verify that no errors appear in the JS console

Offline tests

[No QA]

QA Steps

[No QA]

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

…o-modal"

This reverts commit 135a166, reversing
changes made to 5d48c19.
@mjasikowski mjasikowski requested review from a team as code owners June 18, 2026 19:57
@melvin-bot melvin-bot Bot requested review from flaviadefaria and mollfpr and removed request for a team June 18, 2026 19:57
@melvin-bot

melvin-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 18, 2026 19:58
@mjasikowski mjasikowski changed the title [No QA] Revert #92007 Concierge AI Feature Promo Modal Revert #92007 Concierge AI Feature Promo Modal Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
src/ROUTES.ts 20.86% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/components/Lottie/index.tsx 80.70% <100.00%> (-0.66%) ⬇️
src/components/LottieAnimations/index.tsx 100.00% <ø> (ø)
src/components/Section/index.tsx 100.00% <ø> (ø)
src/libs/Navigation/AppNavigator/AuthScreens.tsx 82.79% <ø> (-0.19%) ⬇️
src/libs/Navigation/guards/index.ts 100.00% <100.00%> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/styles/index.ts 60.93% <ø> (ø)
... and 4 more
... and 11 files with indirect coverage changes

@blimpich blimpich merged commit 813ddb3 into main Jun 18, 2026
49 of 52 checks passed
@blimpich blimpich deleted the revert-pr-92007 branch June 18, 2026 20:18
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jun 18, 2026
Revert #92007 Concierge AI Feature Promo Modal

(cherry picked from commit 813ddb3)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 18, 2026
@IuliiaHerets

Copy link
Copy Markdown

@mjasikowski do you want QA team to retest all linked blockers?

cc @blimpich @mohit6789 @flaviadefaria

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.15-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR reverts #92007, removing the AI features promo modal flow (the modal itself, its navigation guard/routes, animations, and the related src/languages/* and CONST entries) and restoring the prior FeatureTrainingModal behavior.

The promo modal was a transient in-app onboarding/promotion element — it is not documented anywhere under App/docs/articles. The help site documents the underlying AI features (e.g. Expense Assistant, Custom Agents, and How Concierge Analyzes Spend), and those features are unchanged by this revert. A search of App/docs/articles found no references to the promo/training modal or its flow.

Because no documented behavior changes, I did not create a draft help site PR.

@mjasikowski, there is no linked help site PR to review since no docs changes are needed. If you believe a help article should be updated to reflect this behavior, let me know and I'll draft one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.16-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no docs changes required.

This PR reverts #92007, which added the in-app Concierge AI Feature Promo Modal — a one-time promotional/training modal (with Lottie animations, a navigation guard, routes, and localized strings) that advertised existing AI features.

I reviewed the change against the help site files under docs/articles and confirmed:

  • Neither this PR nor the original Concierge AI Feature Promo Modal #92007 touched any docs/articles file. The reverted code is all app UI, navigation, animations, constants, and src/languages/* strings — none of it is help-site content.
  • No help article documents the promo modal itself. The articles that mention these AI features (e.g. concierge-ai/, ai-agents/Create-and-Use-Custom-Agents.md) describe the underlying features — Concierge, Custom Agents, Expense Assistant, spend analysis — which are unchanged by this revert. The promo modal was only an in-product entry point, not a documented feature.

Because the revert removes a transient promotional UI element and does not change any documented feature's availability or behavior, the existing help site content remains accurate. I did not create a draft PR.


@mjasikowski, since no help site changes are required, there is no linked help site PR to review. If you believe an article should still be updated as a result of this revert, let me know and I'll create a draft PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.16-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants