Skip to content

Concierge AI Feature Promo Modal#92007

Merged
mjasikowski merged 51 commits into
Expensify:mainfrom
gijoe0295:feat/ai-feature-promo-modal
Jun 18, 2026
Merged

Concierge AI Feature Promo Modal#92007
mjasikowski merged 51 commits into
Expensify:mainfrom
gijoe0295:feat/ai-feature-promo-modal

Conversation

@gijoe0295

@gijoe0295 gijoe0295 commented May 28, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds promo modal for new AI features:

image image image

Fixed Issues

$ #90820
PROPOSAL:

Tests

  1. Open App
  2. Verify AI features promo modal appears
  3. Verify there are 3 steps in the modal
  4. Verify Back and Next buttons navigate through the pages
  5. Verify horizontal swipes navigate through the pages
  6. Verify the pagination dots change on page change
  7. Verify Let's go/x/tapping outside dismisses the modal
  8. Verify the modal is shown only once
  • Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-06-15.at.12.43.07.mov
Android: mWeb Chrome
Screen.Recording.2026-06-15.at.12.44.06.mov
iOS: Native
Screen.Recording.2026-06-15.at.12.46.58.mov
iOS: mWeb Safari
Screen.Recording.2026-06-15.at.12.53.25.mov
MacOS: Chrome / Safari

Light mode

Screen.Recording.2026-06-08.at.16.16.11.mov

Dark mode

Screen.Recording.2026-06-08.at.17.21.25.mov

Don't intervene onboarding modal

Screen.Recording.2026-06-08.at.17.21.09.mov

@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Would love to see some screenshots or videos here

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Here's the new lottie files:
newfeatures-ai.zip

@gijoe0295 gijoe0295 marked this pull request as ready for review June 8, 2026 10:25
@gijoe0295 gijoe0295 requested review from a team as code owners June 8, 2026 10:25
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
src/ROUTES.ts 20.87% <ø> (+0.27%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
.../FeatureTrainingModal/FeatureTrainingModalBody.tsx 100.00% <100.00%> (ø)
...eTrainingModal/FeatureTrainingModalTextContent.tsx 100.00% <100.00%> (ø)
src/components/Lottie/index.tsx 81.35% <100.00%> (+0.65%) ⬆️
src/components/LottieAnimations/index.tsx 100.00% <ø> (ø)
src/components/Section/index.tsx 100.00% <ø> (ø)
src/libs/Navigation/AppNavigator/AuthScreens.tsx 82.97% <100.00%> (+0.18%) ⬆️
src/libs/Navigation/guards/index.ts 100.00% <100.00%> (ø)
... and 12 more
... and 27 files with indirect coverage changes

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.15-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed the changes in this PR. This is a client-side promo modal (AIFeaturesPromoModal) that introduces no new product behavior — it surfaces three already-shipped Concierge AI features and links each one to its existing help article via a Learn more link.

The three Learn more URLs defined in src/CONST/index.ts:7772-7776 all resolve to help articles that already exist in docs/articles and accurately document each feature:

Modal step Learn more → Existing article
Interactive spend analysis concierge-ai/How-Concierge-Analyzes-Spend How-Concierge-Analyzes-Spend.md
Meet your new expense assistant concierge-ai/Expense-Assistant Expense-Assistant.md
Build your own agents ai-agents/Create-Agent-Rules Create-Agent-Rules.md

Since the modal only points to articles that already exist and describe the same features, no help site updates are needed and I have not opened a draft docs PR.

If a docs change later becomes necessary (e.g. the linked articles need to be expanded for these features), let me know and I'll spin one up.

@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93964 was identified to be related to this PR.

@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93968 was identified to be related to this PR.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker #93969 was identified to be related to this PR

@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93970 was identified to be related to this PR.

@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93973 was identified to be related to this PR.

@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93974 was identified to be related to this PR.

@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93976 was identified to be related to this PR.

blimpich added a commit that referenced this pull request Jun 18, 2026
Revert #92007 Concierge AI Feature Promo Modal
allgandalf pushed a commit to allgandalf/App that referenced this pull request Jun 18, 2026
…ture-promo-modal"

This reverts commit 135a166, reversing
changes made to 5d48c19.
OSBotify pushed a commit that referenced this pull request Jun 18, 2026
Revert #92007 Concierge AI Feature Promo Modal

(cherry picked from commit 813ddb3)

(cherry-picked to staging by puneetlath)
@nlemma

nlemma commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Blocker #93985 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.16-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required.

This PR adds the Concierge AI Feature Promo Modal — a one-time, frontend-only modal that surfaces three existing AI features. It introduces no new product behavior, settings, or flows that the help site would need to document.

The three "Learn more" links in the modal (CONST.AI_FEATURES_PROMO_LEARN_MORE_URLS) all point to help articles that already exist and already cover the promoted features:

Modal step Link target Article status
Interactive spend analysis concierge-ai/How-Concierge-Analyzes-Spend ✅ Exists
Meet your new expense assistant concierge-ai/Expense-Assistant ✅ Exists
Build your own agents ai-agents/Create-Agent-Rules ✅ Exists

Since the linked destinations resolve to live articles and no underlying feature behavior changed, there's nothing to add or update under docs/articles, and I did not open a docs PR.

@gijoe0295 — please confirm you agree the linked articles already reflect the current behavior. If you'd like the promo copy mirrored or any of these articles expanded, reply with @MelvinBot and the specifics and I'll open a draft help site PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.16-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.