[CP staging] Fix Mark as paid button not showing for IOU receiver by neil-marcellini · Pull Request #82016 · Expensify/App

neil-marcellini · 2026-02-10T17:02:39Z

Explanation of Change

PR #81303 added a workspace membership check in the isPayer() function to prevent the Pay button from showing after a user leaves a workspace. However, this check was too broad — it applied to ALL reports with a policyID, including IOU reports (personal 1:1 expenses).

IOU reports can inherit a policyID from the chat report, but the receiver/payer of the IOU may not be a member of that workspace. The new check incorrectly returned false for these users, hiding the "Mark as paid" button.

Root cause: In isPayer(), the condition iouReport?.policyID && iouReport.policyID !== CONST.POLICY.ID_FAKE matched IOU reports that inherited a workspace policyID. When the receiver didn't have access to that policy, !policy was true and isPayer returned false.

Fix: Skip the workspace membership check for IOU reports (!isIOUReport(iouReport)) since they are personal expenses where the payer should always be able to pay if they are the manager, regardless of workspace membership.

Fixed Issues

$ #81955

Tests

Log in with any account
Create and expense and submit it to another account
log in as the receiver
Verify the pay drop down button displays with a "Mark as paid" option

2026-02-10_09-28-29.mp4

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Changes are platform independent. See video above.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The workspace membership check added in #81303 to prevent the Pay button from showing after a user leaves a workspace was too broad. It blocked all reports with a policyID, including IOU reports (personal 1:1 expenses) that inherit a policyID from the chat report. The receiver of such an IOU may not have access to the sender's workspace policy, causing isPayer to incorrectly return false. Skip the workspace membership check for IOU reports since they are personal expenses where the payer should always be able to pay if they are the manager, regardless of workspace membership. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot · 2026-02-10T17:02:47Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-02-10T18:35:41Z

If this requires C+ review and testing, I can help.

situchan · 2026-02-10T18:58:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Before fix:

Screen.Recording.2026-02-11.at.1.16.22.AM.mov

After fix:

Screen.Recording.2026-02-11.at.1.18.39.AM.mov

situchan

melvin-bot · 2026-02-10T19:22:24Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote

LGTM

[CP staging] Fix Mark as paid button not showing for IOU receiver (cherry picked from commit e9911f5) (cherry-picked to staging by lakchote)

OSBotify · 2026-02-10T20:57:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-10T21:35:53Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.16-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-11T06:32:21Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-11T06:56:01Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-12T15:25:20Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

neil-marcellini requested review from a team as code owners February 10, 2026 17:02

melvin-bot Bot assigned neil-marcellini Feb 10, 2026

melvin-bot Bot requested review from Ollyws and trjExpensify and removed request for a team February 10, 2026 17:02

melvin-bot Bot removed the request for review from a team February 10, 2026 17:02

neil-marcellini marked this pull request as draft February 10, 2026 17:04

neil-marcellini added 2 commits February 10, 2026 09:36

Fix lint

61a9ffb

Style fix

1e2a349

neil-marcellini changed the title ~~Fix Mark as paid button not showing for IOU receiver~~ [CP staging] Fix Mark as paid button not showing for IOU receiver Feb 10, 2026

neil-marcellini marked this pull request as ready for review February 10, 2026 18:13

lakchote self-requested a review February 10, 2026 18:16

lakchote requested review from situchan and removed request for Ollyws February 10, 2026 18:57

situchan approved these changes Feb 10, 2026

View reviewed changes

melvin-bot Bot requested a review from MariaHCD February 10, 2026 19:22

lakchote approved these changes Feb 10, 2026

View reviewed changes

lakchote merged commit e9911f5 into main Feb 10, 2026
31 of 32 checks passed

lakchote deleted the neil-fix-mark-as-paid-iou-81955 branch February 10, 2026 20:44

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 10, 2026

OSBotify mentioned this pull request Feb 10, 2026

Deploy Checklist: New Expensify 2026-02-10 #81937

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CP staging] Fix Mark as paid button not showing for IOU receiver#82016

[CP staging] Fix Mark as paid button not showing for IOU receiver#82016
lakchote merged 3 commits into
mainfrom
neil-fix-mark-as-paid-iou-81955

neil-marcellini commented Feb 10, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Feb 10, 2026

Uh oh!

situchan commented Feb 10, 2026

Uh oh!

situchan commented Feb 10, 2026 •

edited

Loading

Uh oh!

situchan left a comment

Uh oh!

melvin-bot Bot commented Feb 10, 2026

Uh oh!

lakchote left a comment

Uh oh!

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

neil-marcellini commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 10, 2026

Uh oh!

situchan commented Feb 10, 2026

Uh oh!

situchan commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 10, 2026

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

neil-marcellini commented Feb 10, 2026 •

edited

Loading

situchan commented Feb 10, 2026 •

edited

Loading