[Home Page] Prevent Pay action from showing after user leaves workspace by adamgrzybowski · Pull Request #81303 · Expensify/App

adamgrzybowski · 2026-02-03T13:26:24Z

Explanation of Change

Prevent Pay action from showing after user leaves workspace

The isPayer helper now verifies workspace membership before allowing the Pay action. Previously, when a user left a workspace, the Pay button could still appear because the function didn't check if the user was still a member.

Changes

Added early return false when policy data is unavailable (indicates user left workspace)
For paid group policies (Corporate/Team), verify membership via isPolicyMemberWithoutPendingDelete to catch cases where policy.role may be stale
Added unit tests covering both scenarios

Fixed Issues

$ #81096
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-03.at.14.09.19.mov

melvin-bot · 2026-02-03T13:26:32Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6f7c6d77a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ZhenjaHorbach · 2026-02-03T18:10:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-02-03.19.53.14.mov

ZhenjaHorbach · 2026-02-03T18:53:53Z

LGTM!

adamgrzybowski · 2026-02-05T13:54:43Z

@grgia I fixed conflicts

grgia · 2026-02-05T16:56:57Z

Is this case also missing an onyx update when the user leaves a workspace?

adamgrzybowski · 2026-02-06T10:06:09Z

@grgia

Is this case also missing an onyx update when the user leaves a workspace?

I am not sure what are you asking for. Could you please explain this a little more?

grgia · 2026-02-06T10:14:47Z

@adamgrzybowski

to catch cases where policy.role may be stale

why is it stale? Is it because an onyx update is missing

adamgrzybowski · 2026-02-06T14:19:48Z

@grgia

When leaving a workspace, only employeeList[email].pendingAction = DELETE is set in the optimistic update policy.role isn't cleared until the API confirms, and the whole policy is removed. So during the transition, policy.role is stale but employeeList reflects the actual state. That's why I'm checking membership there.

grgia

NAB

github-actions · 2026-02-06T16:57:11Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-06T17:03:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81303.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-44e5a05-b42313a023c8c48c909f0a281f7040b059440c33/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-44e5a05-42b11992783b55955d8fdd9d01fa3ea4d93996b2/index.html

Web 🕸️
https://81303.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-06T17:06:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-10T07:24:26Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nkuoch · 2026-02-10T14:37:24Z

@adamgrzybowski can you look? This may have caused #81955 (comment)

izarutskaya · 2026-02-10T16:32:58Z

@adamgrzybowski Any QA steps for this? Thanks

The workspace membership check added in #81303 to prevent the Pay button from showing after a user leaves a workspace was too broad. It blocked all reports with a policyID, including IOU reports (personal 1:1 expenses) that inherit a policyID from the chat report. The receiver of such an IOU may not have access to the sender's workspace policy, causing isPayer to incorrectly return false. Skip the workspace membership check for IOU reports since they are personal expenses where the payer should always be able to pay if they are the manager, regardless of workspace membership. Co-authored-by: Cursor <cursoragent@cursor.com>

OSBotify · 2026-02-11T06:28:54Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ahmedGaber93 · 2026-04-21T11:42:54Z

+        // employeeList may be lazily loaded/partial, so only check if it's present
+        if (isPaidGroupPolicy(iouReport) && !isEmptyObject(policy?.employeeList) && !isPolicyMemberWithoutPendingDelete(currentUserEmailParam, policy)) {
+            return false;
+        }


Hi @adamgrzybowski,

We’re seeing a case here where employeeList is partially loaded and does not include the current user, which causes isPayer to return false.

Do you think it makes sense to guard this by checking
!isEmptyObject(policy?.employeeList?.[currentUserEmailParam]),
or should the backend guarantee that the current user is always included even when returning a partial list?

Not sure if the guard you mentioned solves our problem completely. This partial list behavior is a potential trap for other upcoming features so maybe let's fix the backend? But I don't have a strong opinion on this one

Ahh, the BE fix looks more comprehensive—let’s get @grgia thought on it.

should the backend guarantee that the current user is always included even when returning a partial list?

Yes, though it should already do this.

Reverts the employeeList/membership-based gating added in Expensify#81303 so the Export to integration action is no longer hidden when policy.employeeList is only partially loaded. Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>

Prevent Pay action from showing after user leaves workspace

a6f7c6d

adamgrzybowski requested review from a team as code owners February 3, 2026 13:26

melvin-bot Bot assigned adamgrzybowski Feb 3, 2026

melvin-bot Bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team February 3, 2026 13:26

adamgrzybowski mentioned this pull request Feb 3, 2026

[Home Page] - "Pay 1 report" is shown after approver leaves workspace #81096

Closed

7 tasks

chatgpt-codex-connector Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

adamgrzybowski added 2 commits February 3, 2026 14:40

Fix isPayer blocking payers when policy.employeeList is not loaded

45da66f

Fix IOUTest to use admin session for canIOUBePaid checks

a100d77

adamgrzybowski force-pushed the @adamgrzybowski/fix-isPayer-helper branch from 9c42e71 to a100d77 Compare February 3, 2026 14:16

ZhenjaHorbach approved these changes Feb 3, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia February 3, 2026 18:54

mountiny previously approved these changes Feb 4, 2026

View reviewed changes

grgia previously approved these changes Feb 4, 2026

View reviewed changes

Merge branch 'main' into @adamgrzybowski/fix-isPayer-helper

2f57eb2

adamgrzybowski dismissed stale reviews from grgia and mountiny via 2f57eb2 February 5, 2026 13:53

Merge branch 'main' into @adamgrzybowski/fix-isPayer-helper

c894383

grgia approved these changes Feb 6, 2026

View reviewed changes

grgia merged commit 44e5a05 into Expensify:main Feb 6, 2026
29 checks passed

OSBotify mentioned this pull request Feb 10, 2026

Deploy Checklist: New Expensify 2026-02-10 #81937

Closed

nkuoch mentioned this pull request Feb 10, 2026

[$250] Expense-Mark as paid button is not shown for the IOU receiver. #81955

Closed

7 tasks

neil-marcellini mentioned this pull request Feb 10, 2026

[CP staging] Fix Mark as paid button not showing for IOU receiver #82016

Merged

53 tasks

ahmedGaber93 reviewed Apr 21, 2026

View reviewed changes

ahmedGaber93 mentioned this pull request Jun 16, 2026

[Due for payment 2026-06-26] [Due for payment 2026-06-25] [$250] Both Export to accounting options don't show in the bulk select menu until opening the report first. #92976

Closed

7 tasks

MelvinBot mentioned this pull request Jun 16, 2026

Revert isPayer membership check to restore role-based payer check #93700

Merged

51 tasks

Uh oh!

Conversation

adamgrzybowski commented Feb 3, 2026

Explanation of Change

Prevent Pay action from showing after user leaves workspace

Changes

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ZhenjaHorbach commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Feb 3, 2026

Uh oh!

adamgrzybowski commented Feb 5, 2026

Uh oh!

grgia commented Feb 5, 2026

Uh oh!

adamgrzybowski commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia commented Feb 6, 2026

Uh oh!

adamgrzybowski commented Feb 6, 2026

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Feb 6, 2026

Uh oh!

github-actions Bot commented Feb 6, 2026

Uh oh!

OSBotify commented Feb 6, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

nkuoch commented Feb 10, 2026

Uh oh!

izarutskaya commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

ahmedGaber93 Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

grgia May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ZhenjaHorbach commented Feb 3, 2026 •

edited

Loading

adamgrzybowski commented Feb 6, 2026 •

edited

Loading

ahmedGaber93 Apr 21, 2026 •

edited

Loading