Add original amount by luacmartins · Pull Request #77814 · Expensify/App

luacmartins · 2025-12-16T20:50:04Z

Explanation of Change

Adds the Original amount column to Expenses in Search

Fixed Issues

$ #76869

Tests

Navigate to Reports > Expenses
Select the Columns button in the page header
Add the Original amount column and save
Verify that you see a Original amount column in the table
Verify that you can sort by Original amount

Note: This column is only available for expenses (not reports)

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-12-16.at.5.18.09.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2025-12-16T20:52:40Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff

diff --git a/src/languages/de.ts b/src/languages/de.ts
index d3f2b7f6..4b4cf21b 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -691,6 +691,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: 'Aktion erforderlich',
         duplicate: 'Duplizieren',
         duplicated: 'Dupliziert',
+        originalAmount: 'Ursprünglicher Betrag',
     },
     supportalNoAccess: {
         title: 'Nicht so schnell',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 9d7b9a18..68404034 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -693,6 +693,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: 'Action requise',
         duplicate: 'Dupliquer',
         duplicated: 'Dupliqué',
+        originalAmount: 'Montant d’origine',
     },
     supportalNoAccess: {
         title: 'Pas si vite',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index cdecb098..08730e0a 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -692,6 +692,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: 'Azione richiesta',
         duplicate: 'Duplica',
         duplicated: 'Duplicato',
+        originalAmount: 'Importo originale',
     },
     supportalNoAccess: {
         title: 'Non così in fretta',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 3e62d11f..1cce0054 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -691,6 +691,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: '対応が必要',
         duplicate: '複製',
         duplicated: '重複',
+        originalAmount: '元の金額',
     },
     supportalNoAccess: {
         title: 'ちょっと待ってください',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index eaa4dfc0..f051127c 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -692,6 +692,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: 'Actie vereist',
         duplicate: 'Dupliceren',
         duplicated: 'Gedupliceerd',
+        originalAmount: 'Oorspronkelijk bedrag',
     },
     supportalNoAccess: {
         title: 'Niet zo snel',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 7832371a..2ea67695 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -692,6 +692,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: 'Wymagane działanie',
         duplicate: 'Duplikat',
         duplicated: 'Zduplikowano',
+        originalAmount: 'Kwota pierwotna',
     },
     supportalNoAccess: {
         title: 'Nie tak szybko',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 8e3eec5a..be62a954 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -691,6 +691,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: 'Ação necessária',
         duplicate: 'Duplicar',
         duplicated: 'Duplicado',
+        originalAmount: 'Valor original',
     },
     supportalNoAccess: {
         title: 'Não tão rápido',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0ee2a324..3e67e63b 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -688,6 +688,7 @@ const translations: TranslationDeepObject<typeof en> = {
         actionRequired: '需要操作',
         duplicate: '复制',
         duplicated: '已重复',
+        originalAmount: '原始金额',
     },
     supportalNoAccess: {
         title: '先别急',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

codecov · 2025-12-16T21:05:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`84.54% <ø> (ø)`
...ts/SelectionListWithSections/SearchTableHeader.tsx	`11.11% <ø> (ø)`
src/components/TransactionItemRow/index.tsx	`88.29% <100.00%> (+0.12%)`	⬆️
src/styles/utils/index.ts	`50.07% <100.00%> (+0.07%)`	⬆️
src/libs/SearchUIUtils.ts	`65.36% <0.00%> (-0.12%)`	⬇️
... and 6 files with indirect coverage changes

luacmartins · 2025-12-16T21:50:39Z

Note to self: I need to fix the negative amounts/sorting that depends on some of the logic in #77800

melvin-bot · 2025-12-17T00:19:24Z

@akinwale @JS00001 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

brunovjk · 2025-12-17T02:33:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-16.at.23.30.30.mov

melvin-bot · 2025-12-17T02:35:09Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2025-12-17T03:26:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-18T19:02:41Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T19:32:04Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:46:55Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T13:19:10Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.84-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T23:40:20Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

luacmartins added 3 commits December 16, 2025 13:44

add original amount

eebbf7c

fix undefined value

cd5fd50

move string

ff5a6c3

luacmartins self-assigned this Dec 16, 2025

luacmartins added 4 commits December 16, 2025 13:53

add to types

24810ff

add to types

ee27d26

fix type

b0f2315

add translations

2422fd4

luacmartins added 4 commits December 16, 2025 14:13

fix prettier

d30a647

add es, fix negative amount

0508dbf

gst

e5e751e

rm additional logic

95c9d32

luacmartins added 8 commits December 16, 2025 15:30

use util methods

98596b0

rm incorrect dependency

f5ecfcb

fix dispaly amount, col name

d27bada

use method

290aea3

simplify code

4b7e96d

fix negative sign

f48a5a9

use util method

3e2474a

fix sorting

01d4404

luacmartins commented Dec 16, 2025

View reviewed changes

Comment thread src/CONST/index.ts

luacmartins added 2 commits December 16, 2025 16:35

resolve conflicts

817bdf7

fix prettier

8a8b821

luacmartins requested review from AndrewGable, QichenZhu and brunovjk December 17, 2025 00:19

luacmartins marked this pull request as ready for review December 17, 2025 00:19

melvin-bot Bot removed the request for review from a team December 17, 2025 00:19

luacmartins removed the request for review from akinwale December 17, 2025 00:19

resolve conflicts

ae5e20a

brunovjk approved these changes Dec 17, 2025

View reviewed changes

melvin-bot Bot requested a review from marcochavezf December 17, 2025 02:35

luacmartins removed request for QichenZhu and marcochavezf December 17, 2025 02:41

resolve conflicrts

81f6aa3

AndrewGable previously approved these changes Dec 17, 2025

View reviewed changes

fix prettier

871d2f0

luacmartins dismissed AndrewGable’s stale review via 871d2f0 December 17, 2025 03:00

luacmartins requested a review from AndrewGable December 17, 2025 03:01

AndrewGable approved these changes Dec 17, 2025

View reviewed changes

AndrewGable merged commit edb021d into main Dec 17, 2025
36 checks passed

AndrewGable deleted the cmartins-addoriginalAmount branch December 17, 2025 03:16

OSBotify mentioned this pull request Dec 18, 2025

Deploy Checklist: New Expensify 2025-12-18 #78018

Closed

jponikarchuk mentioned this pull request Dec 18, 2025

[Due for payment 2025-12-30] Reports - Original amount changes to $0.00 after changing the amount #78026

Closed

7 tasks

jponikarchuk mentioned this pull request Dec 18, 2025

[Due for payment 2025-12-30] [HOLD on #78007] Reports - Original amount is 0.00 for scan expense #78049

Closed

7 tasks

This was linked to issues Dec 19, 2025

[Due for payment 2025-12-26] [Custom Columns][Release 4] Add originalAmount column to Search results #76869

Closed

[Due for payment 2025-12-26] [Custom Columns][Release 4] Add billable and reimbursable columns to Search results #76872

Closed

melvin-bot Bot mentioned this pull request Dec 19, 2025

[Due for payment 2025-12-26] [Custom Columns][Release 4] Add originalAmount column to Search results #76869

Closed

Uh oh!

Conversation

luacmartins commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Dec 16, 2025

🦜 Polyglot Parrot! 🦜

Uh oh!

codecov Bot commented Dec 16, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

luacmartins commented Dec 16, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Dec 17, 2025

Uh oh!

brunovjk commented Dec 17, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 17, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

luacmartins commented Dec 16, 2025 •

edited

Loading

codecov Bot commented Dec 16, 2025 •

edited by github-actions Bot

Loading