Fix: Text Report title and Customize report titles are not grayed out while creating workspace in offline#77719
Merged
Merged
Conversation
… while creating workspace in offline
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
… while creating workspace in offline
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| <Section | ||
| isCentralPane | ||
| title={translate('workspace.common.reportTitle')} | ||
| renderTitle={() => ( |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
Creating a new inline arrow function for renderTitle on every render creates a new function reference, which can cause unnecessary re-renders of the Section component even when the actual content hasn't changed.
Suggested fix: Memoize the renderTitle function using useCallback:
const renderReportTitle = useCallback(
() => (
<OfflineWithFeedback pendingAction={policy?.pendingAction}>
<Text style={[styles.textHeadline, styles.cardSectionTitle, styles.accountSettingsSectionTitle, styles.mb1]}>
{translate('workspace.common.reportTitle')}
</Text>
</OfflineWithFeedback>
),
[policy?.pendingAction, styles.textHeadline, styles.cardSectionTitle, styles.accountSettingsSectionTitle, styles.mb1, translate],
);
// Then use it as:
<Section
renderTitle={renderReportTitle}
// ...
/>| </Text> | ||
| </OfflineWithFeedback> | ||
| )} | ||
| renderSubtitle={() => ( |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
Creating a new inline arrow function for renderSubtitle on every render creates a new function reference, which can cause unnecessary re-renders of the Section component even when the actual content hasn't changed.
Suggested fix: Memoize the renderSubtitle function using useCallback:
const renderReportSubtitle = useCallback(
() => (
<OfflineWithFeedback pendingAction={policy?.pendingAction}>
<View style={[[styles.renderHTML, styles.mt1]]}>
<RenderHTML html={translate('workspace.reports.customReportNamesSubtitle')} />
</View>
</OfflineWithFeedback>
),
[policy?.pendingAction, styles.renderHTML, styles.mt1, translate],
);
// Then use it as:
<Section
renderSubtitle={renderReportSubtitle}
// ...
/>
Member
Author
|
@QichenZhu I added an additional MacOS-Chrome.mp4 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-native.webmAndroid: mWeb Chromeandroid-web.webmiOS: HybridAppios-native.moviOS: mWeb Safariios-web.movMacOS: Chrome / Safarimac-web.mov |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.84-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀
|
16 tasks
Merged
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Wrap the Report section header with
OfflineWithFeedbackto make the title and subtitle greyed out when the workspace has a pending actionFixed Issues
$ #77385
PROPOSAL: #77385 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4