Fix - Add a setting for creating a different default report title in New Expensify Collect#59568
Conversation
|
Waiting for the BE changes I wanted to finish up the FE part so I want comments from design perspective @shawnborton. Is there any way I can have the exact px of the spacing of the design in the OP 2025-04-03.15-58-45.mp4 |
|
Looking pretty close! Some quick comments (cc @Expensify/design to check this too): In the empty state, we have too much space at the bottom of this card: The spacing should look more like these from Workflows: Please check the space between the card title and the toggle below it. Again, check the Workflows page for exact spacing. |
|
The Add field row should bleed from edge-to-edge: Again, check Workflows > Add approvals to see how it should actually look: |
|
It looks like the fields that are added aren't lined up correct either: They should be over to the left and right some more. Basically if you fix the padding issue you have with the create row, you should fix this padding issue here as well. But notice how the text in the rows aren't left-aligned with the intro text above? |
|
I think we need a period after "extensive formulas" here: |
|
Yup, similar comment as above, these rows aren't bleeding edge-to-edge: |
|
@FitseTLT I am happy to share the Figma file with you, but can you first just try to reference other parts of the workspace editor and use the exact spacing you see from say the Workflows page? |
|
Yep Will do Pretty helpful guidance Thx 👍 |
|
Here is how it looks now 2025-04-05.00-54-00.mp4 |
|
This is feeling really solid to me! Let us know when it's ready for a test build and I will trigger them for us. |
|
Same! Looking forward to a test build to play around with it a bit more. |
|
Will do after we get the BE fixed 👍 |
|
@FitseTLT I believe we're good to resume the work here now that the BE changes are live! |
|
@shawnborton or @flaviadefaria We used to have a confirm modal for disabling report field feature in More features page do you think we need to have it now? |
|
Can you show me what that looks like? I don't mind the idea of using it here too. |
2025-04-10.18-02-31.mp4 |
|
Oh I really like adding that modal in! |
|
Specifically you mean the Report fields toggle here, right? The 
I agree with that if so. The report fields toggle on the Reports page should be locked (which can be either enabled or disabled) when the accounting solution is connected. When clicked, it shows the alert modal with the reason why and a button to get over to the accounting settings. |
|
@suneox Added |
Thanks for the quick update! The new change set works as expected Screen.Recording.2025-05-08.at.00.40.55.mp4 |
blimpich
left a comment
There was a problem hiding this comment.
Code looks good. @FitseTLT @suneox can one of you provide a video of the new modal for when the user clicks on the toggle and is directed to go to the accounting settings? That way we can all confirm visually its what we expect.
@trjExpensify just to clarify, are you expecting that the toggle will have the "lock" icon on it too?
Yep, it's locked enabled or locked disabled when you're connected to an accounting solution. It all depends on if you're importing coding as report fields or not. But in both cases, you can't "manually" or independently manage report fields once you connect. |
|
P.S @FitseTLT conflicts again. 😅 |
|
@blimpich Conflict resolved |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
MonilBhavsar
left a comment
There was a problem hiding this comment.
This PR might have introduced bug #62065
If anyone could please take a look, thanks!
|
Coming from: #62090. We should move |
| <OfflineWithFeedback pendingAction={reportTitlePendingFields.defaultValue}> | ||
| <MenuItemWithTopDescription | ||
| description={translate('workspace.rules.expenseReportRules.customNameTitle')} | ||
| title={policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE].defaultValue} |
There was a problem hiding this comment.
Passing the title value here like this led to the following issue:
we fixed it by wrapping the value with Str.htmlDecode().
| <FlatList | ||
| data={reportFieldsSections} | ||
| renderItem={renderItem} | ||
| style={[shouldUseNarrowLayout ? styles.mhn5 : styles.mhn8, styles.mt6]} | ||
| scrollEnabled={false} | ||
| /> | ||
| {!hasReportAccountingConnections && ( | ||
| <MenuItem |
| /> | ||
| {!isLoading && ( | ||
| <ScrollView contentContainerStyle={[styles.flexGrow1, styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}> | ||
| <Section |
There was a problem hiding this comment.
This section didn't have offline styling like the other sections.
We wrapped the title and subtitle in OfflineWithFeedback to fix it.
Details
Fixed Issues
$ #59065
PROPOSAL: #59065 (comment)
Tests
Custom report namesandPrevent members from changing report titlesoptions appear (they are moved from the Rules features options)Custom report namesPrevent members from changing report titlesand check that upgrade page is openedOffline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-04-10.18-44-07.mp4
Android: mWeb Chrome
2025-04-10.18-46-40.mp4
iOS: Native
2025-04-10.19-21-19.mp4
iOS: mWeb Safari
2025-04-10.19-23-30.mp4
MacOS: Chrome / Safari
2025-04-10.19-38-14.mp4
MacOS: Desktop
2025-04-10.19-36-36.mp4