Expense - Thread header shows "workspace rules" link in HTML tags #75457#75497
Expense - Thread header shows "workspace rules" link in HTML tags #75457#75497whiletrace wants to merge 2 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
We already have DisplayNamesShouldParseHTMLTest, so if any cases are not covered, please add them there and don't duplicate. Also, please refrain from adding comments if the code explains itself.
There was a problem hiding this comment.
@QichenZhu I am hitting a blocker running the end to end tests due to the process of adding the mock accounts to test properly for the regression I am going to need to come back to this tomorrow fresh after my day job I can resume 11/19/25 16:00. I will update the branch with your requested revisions when I get back to this Note: We should be to solve #75470 in this PR as well.
There was a problem hiding this comment.
If it's urgent, mind if I take over to speed things up?
There was a problem hiding this comment.
If it's urgent, mind if I take over to speed things up?
@QichenZhu I would be very grateful for your assistance.
|
This pull request is outdated and is replaced by this PR |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop