Skip to content

Per diem - Search bar is missing from list of workspaces when creating per diem expense #73872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cead22 merged 2 commits into from
Nov 8, 2025
Merged

Per diem - Search bar is missing from list of workspaces when creating per diem expense #73872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a8fdb
feat: add search bar for per diem ws selection
lorretheboy Oct 30, 2025
e74870b
Merge branch 'main' of https://github.com/Expensify/App into fix/72717
lorretheboy Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
import React, {useMemo} from 'react';
import React, {useCallback, useMemo} from 'react';
import {View} from 'react-native';
import * as Expensicons from '@components/Icon/Expensicons';
import SearchBar from '@components/SearchBar';
import SelectionList from '@components/SelectionList';
import type {ListItem} from '@components/SelectionList/ListItem/types';
import UserListItem from '@components/SelectionList/ListItem/UserListItem';
import Text from '@components/Text';
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
import useLocalize from '@hooks/useLocalize';
import useOnyx from '@hooks/useOnyx';
import useSearchResults from '@hooks/useSearchResults';
import useThemeStyles from '@hooks/useThemeStyles';
import Navigation from '@libs/Navigation/Navigation';
import {getActivePoliciesWithExpenseChatAndPerDiemEnabled, getPerDiemCustomUnit, getPolicy, sortWorkspacesBySelected} from '@libs/PolicyUtils';
import {getDefaultWorkspaceAvatar, getPolicyExpenseChat} from '@libs/ReportUtils';
import tokenizedSearch from '@libs/tokenizedSearch';
import {setCustomUnitID, setMoneyRequestCategory, setMoneyRequestParticipants} from '@userActions/IOU';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
Expand Down Expand Up @@ -70,6 +73,20 @@ function IOURequestStepPerDiemWorkspace({
}));
}, [allPolicies, currentUserLogin, selectedWorkspace, localeCompare]);

const filterWorkspace = useCallback((workspaceOption: WorkspaceListItem, searchInput: string) => {
const results = tokenizedSearch([workspaceOption], searchInput, (option) => [option.text ?? '']);
return results.length > 0;
}, []);

const sortWorkspaces = useCallback(
(data: WorkspaceListItem[]) => {
return data.sort((a, b) => localeCompare(a.text ?? '', b?.text ?? ''));
},
[localeCompare],
);

const [inputValue, setInputValue, filteredWorkspaceOptions] = useSearchResults(workspaceOptions, filterWorkspace, sortWorkspaces);

const selectWorkspace = (item: WorkspaceListItem) => {
const policyExpenseReportID = getPolicyExpenseChat(accountID, item.value)?.reportID;
if (!policyExpenseReportID) {
Expand All @@ -95,12 +112,21 @@ function IOURequestStepPerDiemWorkspace({

return (
<>
<View style={[styles.optionsListSectionHeader]}>
<Text style={[styles.ph5, styles.textLabelSupporting]}>{translate('iou.chooseWorkspace')}</Text>
</View>
{workspaceOptions.length > CONST.SEARCH_ITEM_LIMIT ? (
<SearchBar
label={translate('workspace.common.findWorkspace')}
inputValue={inputValue}
onChangeText={setInputValue}
shouldShowEmptyState={workspaceOptions.length > 0 && filteredWorkspaceOptions.length === 0}
/>
) : (
<View style={[styles.optionsListSectionHeader]}>
<Text style={[styles.ph5, styles.textLabelSupporting]}>{translate('iou.chooseWorkspace')}</Text>
</View>
)}
<SelectionList
key={selectedWorkspace?.policyID}
data={workspaceOptions}
data={filteredWorkspaceOptions}
onSelectRow={selectWorkspace}
shouldSingleExecuteRowSelect
ListItem={UserListItem}
Expand Down
Loading