New Feature: Add `Make splits even` functionality by ikevin127 · Pull Request #73474 · Expensify/App

ikevin127 · 2025-10-25T01:06:24Z

Explanation of Change

Add a Make splits even button into the split edit table that will set the amounts (or percentages in the Split by percentage view) to equal proportions of the original expense amount.

The ‘Make splits even’ button will only be available during the initial split
The 'Make splits even' button will not be available when editing splits to avoid adding more logic to start
When an amount cannot be split evenly, we'll add the remainder to one of the expenses. Ex. a $1 expense, split 3 ways + Make splits even will result in two .33 splits and one .34 split

Fixed Issues

$ #72207
PROPOSAL:

Tests

Even splits

Create an expense for $10.
Select 'Split' from the 'More' menu for the expense.
Tap 'Add split' to create a 3rd split.
Tap 'Add split' to create a 4th split.
Tap 'Make splits even'.
Verify the amounts of the split expenses are all $2.50.

Uneven splits

Case 1

Create an expense for $10.
Select 'Split' from the 'More' menu for the expense.
Tap 'Add split' to create a 3rd split.
Tap 'Make splits even'.
Verify the amounts of the split expenses are $3.33, $3.33, $3.34.

Case 2

Create an expense for $1.01.
Select 'Split' from the 'More' menu for the expense.
Tap 'Add split' to create a 3rd split.
Tap 'Make splits even'.
Verify the amounts of the split expenses are $0.33, $0.33, $0.35.

Case 3

Create an expense for $1001.
Select 'Split' from the 'More' menu for the expense.
Tap 'Add split' to create a 3rd split.
Tap 'Make splits even'.
Verify the amounts of the split expenses are $333.66, $333.66, $333.68.

Editing splits

Create an expense for $10.
Select 'Split' from the 'More' menu for the expense.
Click 'Save'.
Open one of the splits and select 'Edit Split' from the 'More' menu for the expense.
Verify the 'Make splits even' button does not show.

Verify that no errors appear in the JS console

Offline tests

Open a new split flow, add splits, tap “Make splits even” and verify amounts update immediately.
Tap Save; verify optimistic UI (pending indicators: splits grayed out).
Reconnect; verify splits persist and pending clears without errors.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: HybridApp

android-hybrid.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios.mov

iOS: mWeb Safari

ios-mweb.MP4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-10-25T01:06:30Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-25T01:17:56Z

Codecov Report

❌ Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/iou/SplitExpensePage.tsx	0.00%	10 Missing ⚠️
src/libs/actions/IOU.ts	84.61%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/IOUUtils.ts	`62.85% <100.00%> (+62.85%)`	⬆️
src/libs/actions/IOU.ts	`63.51% <84.61%> (+59.23%)`	⬆️
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`

... and 366 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ikevin127 · 2025-10-25T08:21:19Z

@parasharrajat Please hold on reviewing until we get answers to this comment.

parasharrajat · 2025-10-25T11:37:02Z

Better to clarify on issue @ikevin127

garrettmknight · 2025-10-27T11:47:07Z

the issue title mentions + move 'Add split' below which I wasn't sure about so I just added the 'Split evenly' next to the 'Add split' until we clear this up with the design team because the design mock also mentions the button name as Make splits even whereas the issue title + description mentions 'Split evenly'. Current vs post 'Split evenly' addition splits design looks like this compared to the issue OP design:

Let's update to the OP design. We're going to be working on some changes in quick follow ups that require it:

when splits page opens and we have default (2-way split), the 'Split evenly' button does nothing since 2-way split is already even by default when page opens

That's correct. This button shouldn't appear/disappear based on the split amounts, it should always be there, even if it doesn't do anything when the splits are already even.

…7-splitEvenly

melvin-bot · 2025-10-28T23:22:25Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. If you want to automatically generate translations for other locales, you can run the Generate static translations GitHub workflow.

Please look at the code and make sure there are no malicious changes before running the workflow.

If you have the K2 extension, you can simply click: [this button]

…7-splitEvenly

ikevin127 · 2025-10-29T00:17:57Z

@Expensify/design PR was updated to match design UI / functionality. Please review the updated videos and let me know if there are any spacing concerns / changes needed - so otherwise @parasharrajat can start reviewing! 🙌

dubielzyk-expensify · 2025-10-29T05:55:31Z

Looks mostly good to me. Is the height of the page header/app bar the same as the others? I looks like it has more padding on the bottom and cuts off differently to the one underneath:

parasharrajat · 2025-10-29T08:32:01Z

-            sections[0].data.filter((item) => {
-                if (isSelected) {
-                    return isSelected(item);
+            ((sections?.[0]?.data ?? []) as unknown[]).filter((item): item is TItem => {


Please don't infer type to unknown correct the type instead.

Reverted the changes as I went with using listFooterContent (thanks for that), so this type mess is not needed anymore 😅

parasharrajat · 2025-10-29T08:32:08Z

+    // Filter out enhanced sections (those whose items contain a `component` prop)
+    const baseSections = useMemo(() => {
+        const secs = Array.isArray(sections) ? sections : [];
+        return (secs as Array<SectionListDataType<TItem> | {data?: unknown[]}>).filter((section): section is SectionListDataType<TItem> => {


Reverted the changes as I went with using listFooterContent (thanks for that), so this type mess is not needed anymore 😅

parasharrajat · 2025-10-29T09:14:00Z

+    const enhancedSections = useMemo(
+        () => [
+            ...sections,
+            {
+                data: [
+                    {
+                        key: CONST.ENHANCED_SECTIONS.SPLIT_EXPENSE_ACTIONS,
+                        component: ActionButtons,
+                    },
+                ],
+            },
+        ],
+        [sections, ActionButtons],


We don't need these. Can we just use listFooterContent prop on SelectionList

Yes, that's a way better option 👍 💯

dannymcclain · 2025-10-29T14:06:59Z

Looking pretty good to me too! @dubielzyk-expensify Do we want the option rows to be 8px away from the expenses like they are currently? Or should they be 20px away? I don't hate how it is now honestly.

Is there a reason why when you go into Edit splits there's no Make splits even button?

Also, it looks like we have some extra padding above the Save button (apologies for how hard it is to see in these screenshots):

…7-splitEvenly

ikevin127 · 2025-10-29T20:51:41Z

Is the height of the page header/app bar the same as the others? I looks like it has more padding on the bottom and cuts off differently to the one underneath

@dubielzyk-expensify removed that as it was leftover from previously having the buttons up there

Do we want the option rows to be 8px away from the expenses like they are currently? Or should they be 20px away? I don't hate how it is now honestly.

@dannymcclain I kept that space as it is between the expenses (4px coming from the top expense bottom / 4px from the top of the Add split / Make splits even buttons container) - but if we want to increase the space, it can be arranged.

Is there a reason why when you go into Edit splits there's no Make splits even button?

Yes, this was done on purpose as the issue's OP instructed in the Feature description section point 2:

The 'Split evenly' button will not be available when editing splits to avoid adding more logic to start

☝️ It will be probably added eventually, we just skipped it here in the first PR.

Also, it looks like we have some extra padding above the Save button

That was always there (can check current production), but I removed it now, here's how things look with all changes applied:

Screen.Recording.2025-10-29.at.13.33.26.mov

@Expensify/design Are we good with how this looks - any other changes / adjustments required ?

By the way, at the bottom of the Add split / Make splits even buttons container we have 12px margin bottom, this was there before as well, but thought I should mention it in case we want to adjust that as well:

melvin-bot · 2025-10-29T20:54:37Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

…7-splitEvenly

ikevin127 · 2025-11-01T18:56:58Z

Yeah, let's update to keep expected similar result all the time.

@parasharrajat 🟢 Logic updated, now the remainder is always on the last split which will always be the largest. Just note that in the case of $1.01 which when pressed Split, initial split is 51¢ / 50¢, now when pressed Make splits even it changes the splits to 50¢ / 51¢ according to the new logic.

435yyrtghgmht.mov

Removed the additional tests for uneven splits ✅

parasharrajat

Reviewer Checklist

Screenshots

🔲 iOS / native

01.11.2025_19.12.00_REC.mp4

🔲 iOS / Safari

01.11.2025_19.14.17_REC.mp4

🔲 MacOS / Desktop

01.11.2025_19.21.15_REC.mp4

🔲 MacOS / Chrome

01.11.2025_18.55.31_REC.mp4

🔲 Android / Chrome

01.11.2025_19.22.48_REC.mp4

🔲 Android / native

01.11.2025_19.18.48_REC.mp4

🎀 👀 🎀 C+ reviewed

melvin-bot · 2025-11-01T21:56:39Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #72207 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…7-splitEvenly

ikevin127 · 2025-11-03T21:07:27Z

Note: The ❌ eslint / typecheck / prettier are not directly related to this PR, they come from the MoneyRequestParticipantsSelector because I merged main, I'm awaiting for the offending PR author to resolve the issue after which I will merge main again ✅ Asked on Slack about it.

…7-splitEvenly

ikevin127 · 2025-11-04T01:08:19Z

🟢 Ready for review! Merged main again to resolve the☝️ failing workflows coming from main.

youssef-lr

LGTM

OSBotify · 2025-11-04T21:16:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-05T20:38:07Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

This reverts commit 1c4a867, reversing changes made to 35657cf.

Revert #73474 – "New Feature: Add Make splits even functionality"

Revert #73474 – "New Feature: Add Make splits even functionality" (cherry picked from commit 3c43ccb) (cherry-picked to staging by luacmartins)

OSBotify · 2025-11-06T23:20:40Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-06T23:51:43Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.46-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-07T23:31:50Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

ikevin127 added 2 commits October 24, 2025 17:36

Add 'Split evenly' functionality

3ba1532

adjusted languages and tests

c0ffa13

ikevin127 requested a review from a team as a code owner October 25, 2025 01:06

melvin-bot Bot assigned ikevin127 Oct 25, 2025

melvin-bot Bot requested review from parasharrajat and removed request for a team October 25, 2025 01:06

This comment was marked as outdated.

Sign in to view

ikevin127 mentioned this pull request Oct 25, 2025

[Awaiting checklist] [Due for payment 2025-11-20] [Splits in NewDot] [$250] Add 'Split evenly' to the split expense table for new splits + move 'Add split' below #72207

Closed

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

3972abc

…7-splitEvenly

ikevin127 changed the title ~~New Feature: Add Split evenly functionality~~ New Feature: Add Make splits even functionality Oct 28, 2025

updated UI / functionality to match design

2f6ddeb

ikevin127 added 4 commits October 28, 2025 16:29

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

ee2b716

…7-splitEvenly

merged main and fixed lint / types

eed8272

prettier

0f2781c

lint

8c58a6c

parasharrajat suggested changes Oct 29, 2025

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

b55d79e

…7-splitEvenly

code review refactoring and styling

dfac237

removed unused CONST

a2a9cab

ikevin127 added 2 commits November 1, 2025 11:54

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

bab5665

…7-splitEvenly

adjust logic to last split largest

f524202

parasharrajat suggested changes Nov 1, 2025

View reviewed changes

Comment thread src/libs/actions/IOU.ts Outdated

Comment thread src/libs/actions/IOU.ts Outdated

refactoring

544a4f4

parasharrajat approved these changes Nov 1, 2025

View reviewed changes

melvin-bot Bot requested a review from youssef-lr November 1, 2025 21:56

youssef-lr reviewed Nov 2, 2025

View reviewed changes

Comment thread src/libs/actions/IOU.ts Outdated

ikevin127 added 2 commits November 3, 2025 12:39

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

e6e091f

…7-splitEvenly

refactor & reuse calculateAmount

8d1767d

ikevin127 added 2 commits November 3, 2025 16:27

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

5ba8432

…7-splitEvenly

removed unused dependency

a1ace09

youssef-lr approved these changes Nov 4, 2025

View reviewed changes

youssef-lr merged commit 1c4a867 into Expensify:main Nov 4, 2025
26 checks passed

OSBotify mentioned this pull request Nov 5, 2025

Deploy Checklist: New Expensify 2025-11-05 #74371

Closed

79 tasks

francoisl added a commit that referenced this pull request Nov 5, 2025

Revert "Merge pull request #73474 from ikevin127/ikevin127-splitEvenly"

02b489d

This reverts commit 1c4a867, reversing changes made to 35657cf.

francoisl mentioned this pull request Nov 5, 2025

Revert #73474 – "New Feature: Add Make splits even functionality" #74386

Merged

54 tasks

luacmartins added a commit that referenced this pull request Nov 5, 2025

Merge pull request #74386 from Expensify/francois-revert-73474

3c43ccb

Revert #73474 – "New Feature: Add Make splits even functionality"

OSBotify pushed a commit that referenced this pull request Nov 5, 2025

Merge pull request #74386 from Expensify/francois-revert-73474

d79fb18

Revert #73474 – "New Feature: Add Make splits even functionality" (cherry picked from commit 3c43ccb) (cherry-picked to staging by luacmartins)

ikevin127 mentioned this pull request Nov 6, 2025

New Feature: Add Make splits even functionality (rework - negative amount) #74407

Merged

54 tasks

Uh oh!

Conversation

ikevin127 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Even splits

Uneven splits

Editing splits

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 25, 2025

Uh oh!

This comment was marked as outdated.

codecov Bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ikevin127 commented Oct 25, 2025

Uh oh!

parasharrajat commented Oct 25, 2025

Uh oh!

garrettmknight commented Oct 27, 2025

Uh oh!

melvin-bot Bot commented Oct 28, 2025

Uh oh!

ikevin127 commented Oct 29, 2025

Uh oh!

dubielzyk-expensify commented Oct 29, 2025

Uh oh!

parasharrajat Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Oct 29, 2025

Uh oh!

ikevin127 commented Oct 29, 2025

Uh oh!

melvin-bot Bot commented Oct 29, 2025

Uh oh!

ikevin127 commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parasharrajat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

melvin-bot Bot commented Nov 1, 2025

Uh oh!

Uh oh!

ikevin127 commented Nov 3, 2025

Uh oh!

ikevin127 commented Oct 25, 2025 •

edited

Loading

codecov Bot commented Oct 25, 2025 •

edited

Loading

ikevin127 commented Nov 1, 2025 •

edited

Loading

parasharrajat left a comment •

edited

Loading