Skip to content

[No QA] Cleanup - Remove keyboard type numeric, and incorrect uses of phone-pad. #7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 2 commits into from
Jan 18, 2022
Merged

[No QA] Cleanup - Remove keyboard type numeric, and incorrect uses of phone-pad. #7287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9aff2d
fix incorrect uses of phone pad
rushatgabhane Jan 18, 2022
5c82654
rm numeric keyboard type
rushatgabhane Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/CONST.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ const CONST = {
},

KEYBOARD_TYPE: {
NUMERIC: 'numeric',
PHONE_PAD: 'phone-pad',
NUMBER_PAD: 'number-pad',
},
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReimbursementAccount/AddressForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const AddressForm = props => (
<TextInput
label={props.translate('common.zip')}
containerStyles={[styles.mt4]}
keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
value={props.values.zipCode}
onChangeText={value => props.onFieldChange({zipCode: value})}
errorText={props.errors.zipCode ? props.translate('bankAccount.error.zipCode') : ''}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReimbursementAccount/CompanyStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ class CompanyStep extends React.Component {
<TextInput
label={this.props.translate('companyStep.taxIDNumber')}
containerStyles={[styles.mt4]}
keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
onChangeText={value => this.clearErrorAndSetValue('companyTaxID', value)}
value={this.state.companyTaxID}
disabled={shouldDisableCompanyTaxID}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReimbursementAccount/IdentityForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const IdentityForm = (props) => {
<TextInput
label={`${props.translate('common.ssnLast4')}`}
containerStyles={[styles.mt4]}
keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
value={props.values.ssnLast4}
onChangeText={value => props.onFieldChange({ssnLast4: value})}
errorText={props.errors.ssnLast4 ? props.translate('bankAccount.error.ssnLast4') : ''}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/iou/steps/IOUAmountPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class IOUAmountPage extends React.Component {
ref={el => this.textInput = el}
value={this.state.amount}
placeholder="0"
keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
/>
</View>
<View style={[styles.w100, styles.justifyContentEnd]}>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/settings/Payments/AddDebitCardPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class DebitCardPage extends Component {
value={this.state.expirationDate}
maxLength={7}
errorText={this.getErrorText('expirationDate')}
keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
/>
</View>
<View style={[styles.flex1]}>
Expand Down Expand Up @@ -259,7 +259,7 @@ class DebitCardPage extends Component {
<View style={[styles.flex2, styles.mr2]}>
<TextInput
label={this.props.translate('common.zip')}
keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
onChangeText={value => this.clearErrorAndSetValue('addressZipCode', value)}
value={this.state.addressZipCode}
errorText={this.getErrorText('addressZipCode')}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/signin/PasswordForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class PasswordForm extends React.Component {
placeholderTextColor={themeColors.placeholderText}
onChangeText={text => this.setState({twoFactorAuthCode: text})}
onSubmitEditing={this.validateAndSubmitForm}
keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
blurOnSubmit={false}
/>
</View>
Expand Down