[No QA] Cleanup - Remove keyboard type numeric, and incorrect uses of phone-pad.#7287
Merged
Conversation
deetergp
approved these changes
Jan 18, 2022
deetergp
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! :chefkiss:
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
56 tasks
Contributor
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR. Details here
numerickeyboard type is removed, and replaced withnumber-pad(because they're same)Incorrect usage of
phone-padis replaced withnumber-pad. (phone-padis only used for phone numbers.)Fixed Issues
$ #7286
Tests
Tested On
Screenshots
Web
No errors
Mobile Web
Desktop
No errors
iOS
Android