Invisible report is created after submit scan expense from self DM to workspace chat by thelullabyy · Pull Request #72179 · Expensify/App

thelullabyy · 2025-10-09T08:50:19Z

Explanation of Change

Fixed Issues

$#70744
PROPOSAL:#70744 (comment)

Tests

Precondition:

Create and Log in with Expensifail account.
Account has self DM.

Create a workspace
Go to workspace chat
Create an expense
Go to self DM
Create a scan expense in self DM
Click Submit it to someone
Select workspace chat
Click Create expense
Open the expense report
Open any expense row
Click Report field
Verify no new report is created after submitting scan expense from self DM to workspace chat

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Create and Log in with Expensifail account.
Account has self DM.

Create a workspace
Go to workspace chat
Create an expense
Go to self DM
Create a scan expense in self DM
Click Submit it to someone
Select workspace chat
Click Create expense
Open the expense report
Open any expense row
Click Report field
Verify no new report is created after submitting scan expense from self DM to workspace chat

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ndroid.mov

Android: mWeb Chrome

android_ch.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_safari.mov

MacOS: Chrome / Safari

chorme.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-10-09T09:07:03Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…-after-submit-scan-expense

truph01 · 2025-10-09T11:43:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-09.at.18.39.57.mov

Android: mWeb Chrome

Screen.Recording.2025-10-09.at.18.25.11.mov

iOS: HybridApp

Screen.Recording.2025-10-09.at.18.30.14.mov

iOS: mWeb Safari

Screen.Recording.2025-10-09.at.18.41.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-09.at.18.22.18.mov

MacOS: Desktop

Screen.Recording.2025-10-09.at.18.15.59.mov

chuckdries · 2025-10-09T15:40:47Z

 * - we have one, but we can't add more transactions to it due to: report is approved or settled
 */
-function shouldCreateNewMoneyRequestReport(existingIOUReport: OnyxInputOrEntry<Report> | undefined, chatReport: OnyxInputOrEntry<Report>, isScanRequest: boolean): boolean {
+function shouldCreateNewMoneyRequestReport(


Could you add a bullet to the comment above explaining why we don't create a new money request report for submit actions specifically?

@chuckdries I think it would be best to check with the internal team about the logic for when a new money request report should be created. Once we have clarity, we can document all the relevant cases directly in a comment on the shouldCreateNewMoneyRequestReport function—rather than only explaining why we don’t create a new report for submit actions specifically.

I'm a little confused at what you mean. There already is a comment on shouldCreateNewMoneyRequestReport that explains when a new money request report should be created. I'm just saying it'd be helpful to add to it a note about why we're adding an exception for submit actions.

@chuckdries I updated the comment to more clearly. Please help to check it.

Hi @thelullabyy, sorry to be so pedantic about this - I should've been more clear from the get-go. Can you please put in the comment why we're excluding submit actions specifically. Just briefly describe what the bug that we're solving is.

@chuckdries In the comment I added to the function:

It is a SmartScan request, the user is in the ASAP Submit beta, and the action is not "submit"

I was simply highlighting that we create a new report only if the action is not "submit". However, as you pointed out, I wasn’t able to provide a clear explanation for why we don’t create a report when the action is "submit".

The reason I included the action !== CONST.IOU.ACTION.SUBMIT condition was purely to align with the current backend behavior.

If we need a definitive explanation for why a report isn't created in the "submit" case, we should probably reach out to the backend or internal team for clarification.

Similar to the previous comment we added here:

App/src/libs/ReportUtils.ts

Line 10140 in 35e6f75

* - we have one, but it's waiting on the payee adding a bank account

—it simply notes that when the it is waiting on the payee to add a bank account, we create a new report. However, it doesn't explain why that behavior is necessary in this case.

…mit-scan-expense

chuckdries · 2025-10-10T23:14:40Z

Quick question: does this break the submitting an expense from the self DM to the workspace chat when there is no report yet in the workspace chat?

thelullabyy · 2025-10-11T10:57:45Z

@chuckdries

Quick question: does this break the submitting an expense from the self DM to the workspace chat when there is no report yet in the workspace chat?

If there is no report, we still return true because the !existingIOUReport will be false:

App/src/libs/ReportUtils.ts

Line 10149 in 35e6f75

    
           return !existingIOUReport || hasIOUWaitingOnCurrentUserBankAccount(chatReport) || !canAddTransaction(existingIOUReport) || (isScanRequest && isASAPSubmitBetaEnabled);

chuckdries

Tested it, works like a charm. Thanks for putting up with my comments!

OSBotify · 2025-10-13T17:02:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T21:21:51Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:36:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: invisible report is created after submit scan expense from self DM

1e0d031

melvin-bot Bot assigned thelullabyy Oct 9, 2025

update code

de587df

thelullabyy marked this pull request as ready for review October 9, 2025 09:06

thelullabyy requested a review from a team as a code owner October 9, 2025 09:06

melvin-bot Bot requested a review from truph01 October 9, 2025 09:07

melvin-bot Bot removed the request for review from a team October 9, 2025 09:07

Merge branch 'Expensify:main' into fix/70744-invisible-report-created…

ee6902f

…-after-submit-scan-expense

truph01 approved these changes Oct 9, 2025

View reviewed changes

melvin-bot Bot requested a review from chuckdries October 9, 2025 11:44

chuckdries reviewed Oct 9, 2025

View reviewed changes

thelullabyy added 4 commits October 10, 2025 08:57

Merge branch 'main' into fix/70744-invisible-report-created-after-sub…

b2b59fe

…mit-scan-expense

update comment

7a05ce6

update

ddfbc9a

Merge branch 'main' into fix/70744-invisible-report-created-after-sub…

b076de5

…mit-scan-expense

chuckdries approved these changes Oct 13, 2025

View reviewed changes

chuckdries merged commit 9fcc76c into Expensify:main Oct 13, 2025
26 checks passed

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-13 #72503

Closed

92 tasks

mitarachim mentioned this pull request Oct 14, 2025

[Due for payment 2025-10-30] Expense sent from self DM to workspace chat disappears from both chats #72536

Closed

8 tasks

wildan-m mentioned this pull request Apr 13, 2026

[Due for payment 2026-05-18] [$250] Expense - Scan expense add to the 2nd report when adding from 1st report #85217

Closed

7 tasks

Uh oh!

Conversation

thelullabyy commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 9, 2025

Uh oh!

truph01 commented Oct 9, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

chuckdries Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

chuckdries Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

chuckdries Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

chuckdries commented Oct 10, 2025

Uh oh!

thelullabyy commented Oct 11, 2025

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thelullabyy commented Oct 9, 2025 •

edited

Loading