Ensure test drive modal doesn't show again if it has been dismissed by ShridharGoel · Pull Request #71563 · Expensify/App

ShridharGoel · 2025-09-30T10:36:04Z

Explanation of Change

This change aims to ensure that the test drive modal doesn't show again if it has been dismissed.

The solution is to modify the completeOnboarding function to only set testDriveModalDismissed: false if it's not already true. This prevents overwriting the dismissed state when the modal has already been dismissed.

Fixed Issues

$ #70865
PROPOSAL: #70865 (comment)

Tests

Preconditions:

Open an incognito window
Navigate to Expensify
Sign up with the required option
In the onboarding modal - Open console > Application > Cookies
Set the following cookies:
lc-debug = 1
lc-qa = 2
Refresh the page

STR:

Navigate to staging.new.expensify.com
Follow the precondition steps
Sign up with a new user
Select the manage my teams expenses
Select the 1-10 team size
Complete all the remaining onboarding slides relevant to their intent
In the test drive modal, click "Skip".
Verify that the test drive modal does not show again.
Then, sign up with another new user.
Again complete the onboarding flow.
This time, select "Take a test drive" > "Get Started"
Complete the test drive flow.
Verify that the test drive modal does not show again.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-30.at.8.29.01.PM.online-video-cutter.com.mp4

Android: mWeb Chrome

Screen.Recording.2025-09-30.at.6.43.39.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-30.at.18.29.19.online-video-cutter.com.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-30.at.18.27.00.online-video-cutter.com.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-09-30.at.6.22.52.PM.online-video-cutter.com.mp4

MacOS: Desktop

Screen.Recording.2025-09-30.at.6.45.35.PM.online-video-cutter.com.mp4

codecov · 2025-09-30T10:47:21Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #71563      +/-   ##
==========================================
+ Coverage   30.28%   34.89%   +4.61%     
==========================================
  Files        3281     3280       -1     
  Lines      107313   107325      +12     
  Branches    34221    34242      +21     
==========================================
+ Hits        32497    37453    +4956     
+ Misses      74683    69683    -5000     
- Partials      133      189      +56

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-09-30T15:03:53Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2025-10-04T03:24:59Z

@ShridharGoel Please add the verify step to your list of test steps.

ShridharGoel · 2025-10-04T12:37:23Z

Updated.

ShridharGoel · 2025-10-06T13:48:31Z

@akinwale Can you review this when possible? Thanks.

akinwale · 2025-10-08T06:12:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

71563-web-1.mp4

71563-web-2.mp4

MacOS: Desktop

akinwale

LGTM.

akinwale · 2025-10-10T10:54:02Z

@marcochavezf bump on review.

marcochavezf

LGTM, thanks!

OSBotify · 2025-10-10T13:55:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T21:20:27Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:34:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned ShridharGoel Sep 30, 2025

Ensure test drive modal doesn't show again if it has been dismissed

95a6042

ShridharGoel force-pushed the testDrive branch from 67a07f0 to 95a6042 Compare September 30, 2025 11:55

Lint and prettier fixes

7f2af06

ShridharGoel marked this pull request as ready for review September 30, 2025 15:03

ShridharGoel requested a review from a team as a code owner September 30, 2025 15:03

melvin-bot Bot requested review from akinwale and removed request for a team September 30, 2025 15:03

akinwale approved these changes Oct 8, 2025

View reviewed changes

melvin-bot Bot requested a review from marcochavezf October 8, 2025 06:13

marcochavezf approved these changes Oct 10, 2025

View reviewed changes

marcochavezf merged commit 39ffb05 into Expensify:main Oct 10, 2025
21 of 24 checks passed

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-13 #72503

Closed

92 tasks

melvin-bot Bot mentioned this pull request Oct 14, 2025

[Due for payment 2025-10-21] [$250] [EX-43] - Take a Test Drive modal displayed again after completing the flow or when skipped #70865

Closed

16 tasks

Uh oh!

Conversation

ShridharGoel commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 30, 2025

Uh oh!

akinwale commented Oct 4, 2025

Uh oh!

ShridharGoel commented Oct 4, 2025

Uh oh!

ShridharGoel commented Oct 6, 2025

Uh oh!

akinwale commented Oct 8, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

akinwale commented Oct 10, 2025

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShridharGoel commented Sep 30, 2025 •

edited

Loading

codecov Bot commented Sep 30, 2025 •

edited

Loading