[Due for payment 2025-10-21] [$250] [EX-43] - Take a Test Drive modal displayed again after completing the flow or when skipped

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-11
Reproducible in staging?: Y
Reproducible in production?: Unable to validate in Prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation (hyperlinked to channel name): #Lean Convert

Action Performed:

Preconditions:

Open an incognito window
Navigate to Expensify
Sign up with the required option
In the onboarding modal - Open console > Application > Cookies
Set the following cookies (check video for instructions):
-lc-debug = 1
lc-qa = 2
Refresh the page

STR:

1. Navigate to staging.new.expensify.com
2. Follow the precondition steps
3. Sign up with a new user
4. Select the manage my teams expenses
5. Select the 1-10 team size
6. Complete all the remaining onboarding slides relevant to their intent
7. In "How would you like to get started" modal click "Skip" or Select "Take a test drive" > "Get Started"
8. Complete the flow and observe

Expected Result:

After step 7 for both scenarios "Take a test drive" modal should not be displayed

Actual Result:

Take a test drive modal displayed again

Workaround:

Unable to reproduce this if user creates account in the same session without page refresh

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1671.mp4

Recording.1674.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970584915277263786
• Upwork Job ID: 1970584915277263786
• Last Price Increase: 2025-09-23
• Automatic offers:
• ShridharGoel | Contributor | 108942917

Issue Owner

Current Issue Owner: @ShridharGoel

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users experience the "Take a test drive" modal appearing again after they have already completed or skipped the test drive during the onboarding process. This occurs in both scenarios:

1. When users click "Skip" in the "How would you like to get started" modal
2. When users select "Take a test drive" > "Get Started" and complete the flow

The modal should not reappear after completion, but currently it does, creating a poor user experience and confusion.

What is the root cause of that problem?

The root cause is in the completeOnboarding function in src/libs/actions/Report.ts. The function unconditionally sets testDriveModalDismissed: false in the onboarding state during the completion process, even when the modal has already been dismissed by the user.

App/src/libs/actions/Report.ts

Lines 4326 to 4344 in d8ce56d

	if (!shouldSkipTestDriveModal && !(engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && willRedirectToOldDotFromOnboarding)) {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_ONBOARDING,
	value: {testDriveModalDismissed: false},
	});
	successData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_ONBOARDING,
	value: {testDriveModalDismissed: false},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_ONBOARDING,
	value: {testDriveModalDismissed: null},
	});
	}

The issue occurs because:

1. When users dismiss the test drive modal (by clicking "Skip" or completing the test drive), BaseTestDriveModal calls setOnboardingTestDriveModalDismissed() which sets testDriveModalDismissed: true
2. Later, when completeOnboarding is called, it overwrites this value with false
3. The onboarding completion logic checks testDriveModalDismissed !== false to determine if onboarding is complete
4. Since the value was reset to false, the system thinks the modal hasn't been dismissed and shows it again

What changes do you think we should make in order to solve the problem?

The solution is to modify the completeOnboarding function to only set testDriveModalDismissed: false if it's not already true. This prevents overwriting the dismissed state when the modal has already been dismissed.

// We should only set testDriveModalDismissed to false if it's not already true (i.e., if the modal hasn't been dismissed yet).
if (!shouldSkipTestDriveModal && !(engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && willRedirectToOldDotFromOnboarding)) {
    // Only set testDriveModalDismissed to false if it's not already true
    // This prevents overwriting the dismissed state when the modal has already been dismissed
    const [currentOnboarding] = useOnyx(ONYXKEYS.NVP_ONBOARDING);
    if (currentOnboarding?.testDriveModalDismissed !== true) {
        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.NVP_ONBOARDING,
            value: {testDriveModalDismissed: false},
        });

        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.NVP_ONBOARDING,
            value: {testDriveModalDismissed: false},
        });

        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.NVP_ONBOARDING,
            value: {testDriveModalDismissed: null},
        });
    }
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

// New test in tests/actions/ReportTest.ts
it('should not overwrite testDriveModalDismissed when it is already true', async () => {
    await Onyx.set(ONYXKEYS.SESSION, {email: TEST_USER_LOGIN, accountID: TEST_USER_ACCOUNT_ID});
    await Onyx.set(ONYXKEYS.NVP_ONBOARDING, {testDriveModalDismissed: true});
    await waitForBatchedUpdates();

    const adminsChatReportID = '7957055873634067';
    const onboardingPolicyID = 'A70D00C752416807';
    const engagementChoice = CONST.INTRO_CHOICES.MANAGE_TEAM;
    const {onboardingMessages} = getOnboardingMessages();

    Report.completeOnboarding({
        engagementChoice,
        onboardingMessage: onboardingMessages[engagementChoice],
        adminsChatReportID,
        onboardingPolicyID,
        companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
        userReportedIntegration: null,
    });

    await waitForBatchedUpdates();

    const onboarding = await new Promise<OnyxEntry<OnyxTypes.Onboarding>>((resolve) => {
        const connection = Onyx.connect({
            key: ONYXKEYS.NVP_ONBOARDING,
            callback: (data) => {
                Onyx.disconnect(connection);
                resolve(data);
            },
        });
    });

    // testDriveModalDismissed should remain true and not be overwritten to false
    expect(onboarding?.testDriveModalDismissed).toBe(true);
});

[lorretheboy]

Looks like this is the offending PR #70531

[melvin-bot]

@OfstadC Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970584915277263786

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)