fix: show and select accounting on feature selection modal#71486
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #71486 +/- ##
==========================================
- Coverage 34.90% 34.90% -0.01%
==========================================
Files 3277 3277
Lines 107212 107213 +1
Branches 34192 34196 +4
==========================================
- Hits 37421 37420 -1
- Misses 69598 69600 +2
Partials 193 193 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
Translation is confirmed in https://expensify.slack.com/archives/C01GTK53T8Q/p1759162213838049 |
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@abdulrahuman5196 is there anything blocking the review? |
|
checking now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-13.at.2.06.32.AM.movAndroid: mWeb ChromeScreen.Recording.2025-10-13.at.1.50.45.AM.moviOS: HybridAppScreen.Recording.2025-10-13.at.1.46.19.AM.moviOS: mWeb SafariScreen.Recording.2025-10-13.at.1.29.33.AM.movMacOS: Chrome / SafariScreen.Recording.2025-10-13.at.1.22.08.AM.movMacOS: DesktopScreen.Recording.2025-10-13.at.1.23.10.AM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @amyevans
🎀 👀 🎀
C+ Reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀
|
Explanation of Change
Fixed Issues
$ #69300
PROPOSAL: #69300 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-09-30.at.00.02.26.mov
Android: mWeb Chrome
Screen.Recording.2025-09-30.at.00.03.24.mov
iOS: Native
Screen.Recording.2025-09-30.at.00.03.56.mov
iOS: mWeb Safari
Screen.Recording.2025-09-30.at.00.04.52.mov
MacOS: Chrome / Safari
Screen.Recording.2025-09-30.at.00.05.26.mov
MacOS: Desktop
Screen.Recording.2025-09-30.at.00.05.57.mov