[Due for payment 2025-10-21] Accounting is not showing up in feature selection modal

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Signup as a new user
2. Choose manage my team, 1-10,
3. Choose "None" in the Accounting modal
4. Observe the "What features are you interested in?" modal

Expected Result:

Options shown in first set:
Categories, Accounting (unchecked), Company Cards, Approvals

Options shown unchecked below:
Invoices, Rules, Distance tracking, Expensify Cards, Tags, Per Diem

Reference:

New copy: Here are our most popular features:

Actual Result:

Options displayed are incorrect

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

@danielrvidal Isn't company cards mean corporate cards?

[samranahm]

Agree with @FitseTLT let's close this one

[dylanexpensify]

Taking over! The problem is the selector isn't displaying the options correctly. Here's what we're expecting to show:

[dylanexpensify]

cc @dukenv0307 @ishpaul777 in case you have any ideas as you helped implement

[dylanexpensify]

Updated OP

[dukenv0307]

@dylanexpensify You mean the accounting option isn't selected, right?

[samranahm]

@dylanexpensify IMO this is expected, looking here

App/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

Lines 76 to 82 in d3af0b4

	{
	id: 'accounting',
	title: translate('workspace.moreFeatures.connections.title'),
	icon: Illustrations.Accounting,
	enabledByDefault: !!userReportedIntegration,
	apiEndpoint: WRITE_COMMANDS.ENABLE_POLICY_CONNECTIONS,
	},

If user choose none in onboarding accounting page, we don't enable accounting feature.

[dylanexpensify]

Ahh, I see! Expected behavior is we'd still show the accounting option in the modal for feature-selection, even if they clicked none for accounting.