-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: Android - Search - Keyboard is not automatically opened despite input being focused. #71056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amyevans
merged 8 commits into
Expensify:main
from
Krishna2323:krishna2323/issue/69034-2
Oct 16, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ec6287d
fix: Android - Search - Keyboard is not automatically opened despite …
Krishna2323 e94ca35
update hook to use useFocusEffect.
Krishna2323 b06c705
use requestAnimationFrame.
Krishna2323 18ecdcd
revert back to setTimeout.
Krishna2323 8fee063
Merge branch 'Expensify:main' into krishna2323/issue/69034-2
Krishna2323 5629265
perform cleanup.
Krishna2323 ffc9cd7
add type file for useFocusAfterNav
Krishna2323 651a88f
Merge branch 'Expensify:main' into krishna2323/issue/69034-2
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import {useFocusEffect} from '@react-navigation/native'; | ||
| import CONST from '@src/CONST'; | ||
| import type UseFocusAfterNav from './type'; | ||
|
|
||
| /** We added a delay to focus on text input to allow navigation/modal animations to get completed, | ||
| see issue https://github.com/Expensify/App/issues/65855 for more details */ | ||
| const useFocusAfterNav: UseFocusAfterNav = (ref) => { | ||
| useFocusEffect(() => { | ||
| const timeoutId = setTimeout(() => { | ||
| ref.current?.focus(); | ||
| }, CONST.ANIMATED_TRANSITION); | ||
|
|
||
| return () => clearTimeout(timeoutId); | ||
| }); | ||
| return false; | ||
| }; | ||
|
|
||
| export default useFocusAfterNav; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import type UseFocusAfterNav from './type'; | ||
|
|
||
| const useFocusAfterNav: UseFocusAfterNav = () => { | ||
| return true; | ||
| }; | ||
|
|
||
| export default useFocusAfterNav; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import type {RefObject} from 'react'; | ||
| import type {AnimatedTextInputRef} from '@components/RNTextInput'; | ||
|
|
||
| type UseFocusAfterNav = (ref: RefObject<AnimatedTextInputRef | null>) => boolean; | ||
|
|
||
| export default UseFocusAfterNav; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the above a clean way to write things ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is! updated.