fix: Android - Search - Keyboard is not automatically opened despite input being focused.#71056
Merged
Merged
Conversation
…input being focused. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@hoangzinh sorry for the bump, @allgandalf will review this. |
Codecov Report❌ Patch coverage is
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
allgandalf
suggested changes
Oct 2, 2025
| import type {RefObject} from 'react'; | ||
| import type {AnimatedTextInputRef} from '@components/RNTextInput'; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
Contributor
There was a problem hiding this comment.
why are we disabling this?
| /** We added a delay to focus on text input to allow navigation/modal animations to get completed, | ||
| *see issue https://github.com/Expensify/App/issues/65855 for more details | ||
| */ | ||
| const useFocusAfterNav = (ref: RefObject<AnimatedTextInputRef | null>) => { |
Contributor
There was a problem hiding this comment.
Please create a separate type file lets keep the code DRY
allgandalf
reviewed
Oct 2, 2025
| return false; | ||
| }; | ||
|
|
||
| export default useFocusAfterNav; |
Contributor
There was a problem hiding this comment.
import {useFocusEffect} from '@react-navigation/native';
import {RefObject} from 'react';
import type {AnimatedTextInputRef} from '@components/RNTextInput';
import CONST from '@src/CONST';
const useFocusAfterNav = (ref: RefObject<AnimatedTextInputRef | null>) => {
useFocusEffect(() => {
const timeoutId = setTimeout(() => {
ref.current?.focus();
}, CONST.ANIMATED_TRANSITION);
return () => clearTimeout(timeoutId);
});
};
export default useFocusAfterNav;isn't the above a clean way to write things ?
Contributor
Author
There was a problem hiding this comment.
Yes it is! updated.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
allgandalf
reviewed
Oct 2, 2025
allgandalf
left a comment
Contributor
There was a problem hiding this comment.
sweet!!, will test these changes and get back
Contributor
Author
|
@allgandalf 👋🏻👀 |
Contributor
|
On my list for today |
Contributor
|
@Krishna2323 can you merge main, i tested the code and it was very weird for me |
Contributor
|
Testing fresh later today |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-16.at.11.04.51.AM.movAndroid: mWeb ChromeScreen.Recording.2025-10-16.at.11.05.53.AM.moviOS: HybridAppScreen.Recording.2025-10-16.at.10.54.01.AM.moviOS: mWeb SafariScreen.Recording.2025-10-16.at.10.55.32.AM.movMacOS: Chrome / SafariScreen.Recording.2025-10-16.at.10.49.32.AM.movMacOS: DesktopScreen.Recording.2025-10-16.at.11.22.33.AM.mov |
allgandalf
approved these changes
Oct 16, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
67 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.33-0 🚀
|
|
@Krishna2323 QA team still faces this original issue on Android 1760667303762.screen-20251017-051415.mp4 |
Contributor
|
@Krishna2323 can you please take a look |
Contributor
|
@IuliiaHerets can you please test again? since from our testing the fix should work ;) |
|
@allgandalf issue is still reproduced for the QA team, build v9.2.33-4 mobizen_20251018_071455.mp4 |
16 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀
|
8 tasks
54 tasks
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #65855
$ #69034
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4