Search: Don't display violations that are dismissed

src/components/SelectionList/Search/TransactionGroupListItem.tsx

@@ -36,6 +36,7 @@ import Navigation from '@libs/Navigation/Navigation';
 import {getReportAction} from '@libs/ReportActionsUtils';
 import {canAddTransaction as canAddTransactionUtil, getAddExpenseDropdownOptions} from '@libs/ReportUtils';
 import {createAndOpenSearchTransactionThread, getColumnsToShow, getSections} from '@libs/SearchUIUtils';
+import {getTransactionViolations} from '@libs/TransactionUtils';
 import variables from '@styles/variables';
 import {setActiveTransactionThreadIDs} from '@userActions/TransactionThreadNavigation';
 import CONST from '@src/CONST';
@@ -351,7 +352,7 @@ function TransactionGroupListItem<TItem extends ListItem>({
                                             key={transaction.transactionID}
                                             report={transaction.report}
                                             transactionItem={transaction}
-                                            violations={violations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`]}
+                                            violations={getTransactionViolations(transaction, violations)}
                                             isSelected={!!transaction.isSelected}
                                             dateColumnSize={dateColumnSize}
                                             amountColumnSize={amountColumnSize}

src/components/SelectionList/Search/TransactionListItem.tsx

@@ -14,6 +14,7 @@ import useSyncFocus from '@hooks/useSyncFocus';
 import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import {handleActionButtonPress as handleActionButtonPressUtil} from '@libs/actions/Search';
+import {getTransactionViolations} from '@libs/TransactionUtils';
 import variables from '@styles/variables';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
@@ -74,6 +75,8 @@ function TransactionListItem<TItem extends ListItem>({
         };
     }, [transactionItem]);
 
+    const transactionViolations = useMemo(() => getTransactionViolations(transactionItem, violations), [transactionItem, violations]);
+
     const handleActionButtonPress = useCallback(() => {
         handleActionButtonPressUtil(
             currentSearchHash,
@@ -148,7 +151,7 @@ function TransactionListItem<TItem extends ListItem>({
                     shouldShowCheckbox={!!canSelectMultiple}
                     style={[styles.p3, shouldUseNarrowLayout ? styles.pt2 : {}]}
                     areAllOptionalColumnsHidden={areAllOptionalColumnsHidden}
-                    violations={violations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionItem.transactionID}`]}
+                    violations={transactionViolations}
                 />
             </PressableWithFeedback>
         </OfflineWithFeedback>

src/hooks/useTransactionsAndViolationsForReport.ts

@@ -1,17 +1,35 @@
+import {useMemo} from 'react';
 import {useAllReportsTransactionsAndViolations} from '@components/OnyxListItemProvider';
-import CONST from '@src/CONST';
+import {getTransactionViolations} from '@libs/TransactionUtils';
+import ONYXKEYS from '@src/ONYXKEYS';
+import type {TransactionViolations} from '@src/types/onyx';
 import type {ReportTransactionsAndViolations} from '@src/types/onyx/DerivedValues';
 
 const DEFAULT_RETURN_VALUE: ReportTransactionsAndViolations = {transactions: {}, violations: {}};
 
 function useTransactionsAndViolationsForReport(reportID?: string) {
     const allReportsTransactionsAndViolations = useAllReportsTransactionsAndViolations();
 
-    if (!reportID) {
-        return DEFAULT_RETURN_VALUE;
-    }
+    const {transactions, violations} = reportID ? (allReportsTransactionsAndViolations?.[reportID] ?? DEFAULT_RETURN_VALUE) : DEFAULT_RETURN_VALUE;
 
-    return allReportsTransactionsAndViolations?.[reportID ?? CONST.DEFAULT_NUMBER_ID] ?? DEFAULT_RETURN_VALUE;
+    const transactionsAndViolations = useMemo<ReportTransactionsAndViolations>(() => {
+        const filteredViolations = Object.keys(violations).reduce(
+            (filteredTransactionViolations, transactionViolationKey) => {
+                const transactionID = transactionViolationKey.split('_').at(1) ?? '';
+                const transaction = transactions[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
+
+                // This is our accumulator, it's okay to reassign
+                // eslint-disable-next-line no-param-reassign
+                filteredTransactionViolations[transactionViolationKey] = getTransactionViolations(transaction, violations) ?? [];
+                return filteredTransactionViolations;
+            },
+            {} as Record<string, TransactionViolations>,
+        );
+
+        return {transactions, violations: filteredViolations};
+    }, [transactions, violations]);
+
+    return transactionsAndViolations;
 }
 
 export default useTransactionsAndViolationsForReport;

src/libs/ReportPrimaryActionUtils.ts

@@ -255,7 +255,7 @@ function isRemoveHoldAction(report: Report, chatReport: OnyxEntry<Report>, repor
 }
 
 function isReviewDuplicatesAction(report: Report, reportTransactions: Transaction[]) {
-    const hasDuplicates = reportTransactions.some((transaction) => isDuplicate(transaction));
+    const hasDuplicates = reportTransactions.some((transaction) => isDuplicate(transaction, true));
 
     if (!hasDuplicates) {
         return false;

src/libs/ReportSecondaryActionUtils.ts

@@ -213,7 +213,7 @@ function isApproveAction(report: Report, reportTransactions: Transaction[], viol
         return false;
     }
     const isExpenseReport = isExpenseReportUtils(report);
-    const reportHasDuplicatedTransactions = reportTransactions.some((transaction) => isDuplicate(transaction));
+    const reportHasDuplicatedTransactions = reportTransactions.some((transaction) => isDuplicate(transaction, true));
 
     if (isExpenseReport && isProcessingReport && reportHasDuplicatedTransactions) {
         return true;