Skip to content

add character limit - #7039

Merged
thienlnam merged 1 commit into
Expensify:mainfrom
thesahindia:add-character-limit
Jan 5, 2022
Merged

add character limit#7039
thienlnam merged 1 commit into
Expensify:mainfrom
thesahindia:add-character-limit

Conversation

@thesahindia

Copy link
Copy Markdown
Member

Details

Fixed Issues

Added character limit on zip code in debit card

$ #7013

Tests

QA Steps

Open app

  1. Navigate to Settings > Payments > Add payments method
  2. Select Debit card
  3. Enter more than 5 char in ZIP field

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-05.at.9.33.18.PM.mov

Mobile Web

Desktop

iOS

Android

@thesahindia
thesahindia requested a review from a team as a code owner January 5, 2022 16:55
@MelvinBot
MelvinBot requested review from thienlnam and removed request for a team January 5, 2022 16:55
@thienlnam
thienlnam merged commit 90eeba8 into Expensify:main Jan 5, 2022
@OSBotify

OSBotify commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.26-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants