[HOLD for payment 2022-01-17] Bank account zip field has a character limit but debit card field has no limit - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to Settings > Payments > Add payments method
3. Select Debit card
4. Enter more than 5 char in ZIP field
5. Enter more than 16 char in Card number field

Expected Result:

Bank account zip field has a character limit but debit card field has no limit

Actual Result:

Bank account zip field has a character limit but debit card field has no limit

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2021-12-30.at.6.48.16.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640870547263400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thesahindia]

Proposal

we need to add maxLength={CONST.BANK_ACCOUNT.MAX_LENGTH.ZIP_CODE} below -

App/src/pages/settings/Payments/AddDebitCardPage.js

Lines 252 to 256 in 036d1f3

	<ExpensiTextInput
	label={this.props.translate('common.zip')}
	keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD}
	onChangeText={value => this.clearErrorAndSetValue('addressZipCode', value)}
	value={this.state.addressZipCode}

should we add a new CONST for debit card zip code as the above CONST is for Bank account?

[thienlnam]

Proposal looks good, we can keep the constant the same since they are both for address zip codes

[MelvinBot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Working on this now!

[dylanexpensify]

Posted!

Internal: https://www.upwork.com/ab/applicants/1478712359720198144/job-details
External: https://www.upwork.com/jobs/~01d7834a77e2677e35

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)