Add New Task Section to Reports & Fix Task Bugs by JS00001 · Pull Request #61097 · Expensify/App

JS00001 · 2025-04-29T17:17:39Z

Explanation of Change

Added 'Tasks' view to search, with the ability to view date, title, description, created by, shared in, assignee, and view action (and complete the task via action).

Added new advanced filters for tasks specifically, including title, assignee and created by.

Also fixed various issues from previous deploy including:

The ability to search by keyword (by just entering a string in the searchbar).
Removed deleted tasks showing up in the search view

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/487125
$ https://github.com/Expensify/Expensify/issues/487128

Tests

Test all features of the new Task search, including applying random advanced filters combined with status filtering, and various search queries.
Test various task creation methods, such as creating tasks in DMs and in Threads and creating tasks with no description/tasks with no assignee, etc.

Verify that no errors appear in the JS console

Offline tests

When the user is offline, they should not be able to mark tasks as completed

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

iOS: Native
https://github.com/user-attachments/assets/37da47f0-f802-4b29-9bdc-4ae6e5856c61

iOS: mWeb Safari
https://github.com/user-attachments/assets/bf5d9379-9c32-41c6-bb21-d59aa228db49

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/b8e7d553-516a-4cf4-b988-53c111069211

…ontext

…o jsenyitko-task-context

…ontext

…o jsenyitko-task-context

This reverts commit 7caf74c, reversing changes made to 758691e.

…ontext

melvin-bot · 2025-05-01T13:36:28Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-05-01T17:37:28Z

reviewing...

dukenv0307 · 2025-05-02T10:03:20Z

+    icon?: Icon;
+};
+
+function AvatarWithTextCell({reportName, icon}: AvatarWithTextCellProps) {


Why don't we use UserInfoCell?

This is not a user-info cell exclusively. This is more generic for things such as room icons, groupchats, etc. Thus, we pass in the icon rather than only allowing user icons

dukenv0307 · 2025-05-02T10:23:25Z

This PR works well, I just left some minor comments @JS00001

…ontext

luacmartins · 2025-05-05T16:45:29Z

@dukenv0307 seems like the comment was addressed. Could you please continue review?

luacmartins

LGTM

dukenv0307 · 2025-05-05T17:32:19Z

on it now

dukenv0307 · 2025-05-05T17:44:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-06.at.00.42.54.mov

Android: mWeb Chrome

Screen.Recording.2025-05-06.at.00.39.57.mov

iOS: Native

Screen.Recording.2025-05-06.at.00.42.27.mov

iOS: mWeb Safari

Screen.Recording.2025-05-06.at.00.39.26.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-06.at.00.35.24.mov

Screen.Recording.2025-05-06.at.00.37.14.mov

MacOS: Desktop

Screen.Recording.2025-05-06.at.00.44.10.mov

dukenv0307

LGTM

melvin-bot · 2025-05-05T17:45:17Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-05-05T17:45:20Z

🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #61386.

OSBotify · 2025-05-05T17:56:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-06T01:27:23Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-07T00:08:07Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

rushatgabhane · 2025-07-17T14:19:04Z

realllly minor issue
this PR had a wrong spanish translation
#64170 (comment)

JS00001 added 8 commits April 29, 2025 09:57

add names tos earch filters

238ea7d

Merge branch 'main' of github.com:Expensify/App into jsenyitko-task-c…

9260bd5

…ontext

Merge branch 'main' of github.com:Expensify/App into jsenyitko-task-c…

d932391

…ontext

Merge branch 'jsenyitko-task-context' of github.com:Expensify/App int…

3abec95

…o jsenyitko-task-context

Merge branch 'main' of github.com:Expensify/App into jsenyitko-task-c…

b4a4713

…ontext

Merge branch 'jsenyitko-task-context' of github.com:Expensify/App int…

80e69c4

…o jsenyitko-task-context

Revert "Merge pull request #61064 from Expensify/revert-b249592"

cfe8bcc

This reverts commit 7caf74c, reversing changes made to 758691e.

Merge branch 'main' of github.com:Expensify/App into jsenyitko-task-c…

10d737c

…ontext

JS00001 changed the title ~~Jsenyitko task context~~ Add New Task Section to Reports & Fix Task Bugs Apr 29, 2025

JS00001 self-assigned this Apr 29, 2025

Merge branch 'main' of github.com:Expensify/App into jsenyitko-task-c…

5199ff7

…ontext

JS00001 marked this pull request as ready for review May 1, 2025 13:36

JS00001 requested review from a team as code owners May 1, 2025 13:36

melvin-bot Bot requested a review from dukenv0307 May 1, 2025 13:36

JS00001 requested review from luacmartins and removed request for dukenv0307 May 1, 2025 13:36

melvin-bot Bot removed the request for review from a team May 1, 2025 13:36

JS00001 requested a review from dukenv0307 May 1, 2025 13:40

dukenv0307 reviewed May 2, 2025

View reviewed changes

Comment thread src/components/SelectionList/Search/DateCell.tsx

JS00001 added 3 commits May 5, 2025 07:29

Merge branch 'main' of github.com:Expensify/App into jsenyitko-task-c…

a3b9da3

…ontext

remove old date cell

5c14b8c

fix typescript errors from merge

2e5ed02

JS00001 requested a review from dukenv0307 May 5, 2025 11:56

luacmartins approved these changes May 5, 2025

View reviewed changes

dukenv0307 approved these changes May 5, 2025

View reviewed changes

melvin-bot Bot requested a review from nkuoch May 5, 2025 17:45

melvin-bot Bot mentioned this pull request May 5, 2025

[Hold for payment 2025-05-14] Payment issue for E/App PR#61097 #61386

Closed

JS00001 merged commit 540b1fa into main May 5, 2025

JS00001 deleted the jsenyitko-task-context branch May 5, 2025 17:47

github-actions Bot mentioned this pull request May 6, 2025

Deploy Checklist: New Expensify 2025-05-06 #61424

Closed

77 tasks

mitarachim mentioned this pull request May 6, 2025

[$250] Reports - GBR on inbox button disappears and reappears when marking tasks as completed. #61497

Closed

8 tasks

rushatgabhane mentioned this pull request Jul 17, 2025

[Need BZ checklist] Reports - Wrong translation for "Take a test drive" #64170

Closed

8 tasks

Uh oh!

Conversation

JS00001 commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 1, 2025

Uh oh!

dukenv0307 commented May 1, 2025

Uh oh!

dukenv0307 May 2, 2025

Choose a reason for hiding this comment

Uh oh!

JS00001 May 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dukenv0307 commented May 2, 2025

Uh oh!

luacmartins commented May 5, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented May 5, 2025

Uh oh!

dukenv0307 commented May 5, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 5, 2025

Uh oh!

melvin-bot Bot commented May 5, 2025

Uh oh!

OSBotify commented May 5, 2025

Uh oh!

github-actions Bot commented May 6, 2025

Uh oh!

github-actions Bot commented May 7, 2025

Uh oh!

rushatgabhane commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JS00001 commented Apr 29, 2025 •

edited

Loading

rushatgabhane commented Jul 17, 2025 •

edited

Loading