-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: keep validate code modal when open test tool menu #59997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,6 +73,7 @@ function ValidateCodeActionModal({ | |
| useNativeDriver | ||
| shouldUseModalPaddingStyle={false} | ||
| animationInTiming={disableAnimation ? 1 : undefined} | ||
| canBeClosedByOtherModal={false} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey guys! After this change, the modal can no longer be closed with the Android back button. Is this an expected behavior?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. We were discussing it here. Will prioritize to revert this one. |
||
| > | ||
| <ScreenWrapper | ||
| includeSafeAreaPaddingBottom | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is good to add, but was this for code quality or to fix the bug?