[Due for payment 2025-05-05] [$250] Contact method - Opening release options (Ctrl+d) closes verification contact method modal

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+b20310@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to Settings> Profile> Contact method> Add new contact method> Add
2. When verification modal opens press Ctrl+D

Expected Result:

Verification contact method modal should not dismiss

Actual Result:

Verification contact method modal is dismissed when open release options

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6782740_1742995436141.Recording__5277.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021905017759429822024
• Upwork Job ID: 1905017759429822024
• Last Price Increase: 2025-03-26
• Automatic offers:
• daledah | Contributor | 106824233

Issue Owner

Current Issue Owner: @jasperhuangg

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mateusslezinsky]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening release options (Ctrl+d) closes verification contact method modal.

What is the root cause of that problem?

In this line any modals that are already visible are closed when another modal is mounted.

App/src/components/Modal/BaseModal.tsx

Line 136 in 6b516e2

removeOnCloseListener = setCloseModal(onClose);

What changes do you think we should make in order to solve the problem?

Checking for modal type is not RIGHT_DOCKED before calling this method.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Include more specific checks to this useEffect to ensure we are closing the correct modals and leaving opened the right ones.

What alternative solutions did you explore? (Optional)

Moving the isValidateCodeActionModalVisible to Onyx so that the open status can be checked at BaseModal.tsx's useEffect (previously referenced line).

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Line 48 in 6b516e2

const [isValidateCodeActionModalVisible, setIsValidateCodeActionModalVisible] = useState(false);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @mateusslezinsky! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mateusslezinsky]

Contributor details
Your Expensify account email: droidshatt@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f6ac47990000c887

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021905017759429822024

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)