Navigating to a thread from the Search page doesn’t take you to the chat by thelullabyy · Pull Request #58628 · Expensify/App

thelullabyy · 2025-03-18T11:20:26Z

Explanation of Change

Fixed Issues

$#58255
PROPOSAL:#58255 (comment)

Tests

Click the Search icon from the Inbox page
Search for text you know exists in a thread by searching for type:chat "", replacing with your search value
Click on the result in the search page
Click on the top chat in the thread to try and navigate to that thread in your inbox
Verify you’re routed to the message that you clicked on

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click the Search icon from the Inbox page
Search for text you know exists in a thread by searching for type:chat "", replacing with your search value
Click on the result in the search page
Click on the top chat in the thread to try and navigate to that thread in your inbox
Verify you’re routed to the message that you clicked on

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

13b5249b-9140-44d1-af43-5b2c428601d0_xLkR2FNJ.mp4

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

chorme.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-03-18T11:48:18Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2025-03-19T15:39:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-03.at.11.57.20.mov

Android: mWeb Chrome

Screen.Recording.2025-04-03.at.11.43.36.mov

iOS: Native

Screen.Recording.2025-04-03.at.11.41.34.mov

iOS: mWeb Safari

Screen.Recording.2025-04-03.at.11.42.30.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-03.at.11.31.00.mov

MacOS: Desktop

Screen.Recording.2025-04-03.at.11.45.08.mov

eVoloshchak

@thelullabyy, this doesn't work for me, could you double-check please?

Screen.Recording.2025-03-19.at.22.46.14.mov

Change the last step to

Verify you’re routed to the message that you clicked on

thelullabyy · 2025-03-20T08:45:50Z

@eVoloshchak As in the issue description, the action here is clicking on the thread message, not the icon. Could you check again? Thanks

eVoloshchak · 2025-03-20T13:18:49Z

That's right, I wonder why do we have two separate handlers for that. Confirming the expected behavior in #58255 (comment)

Bug:

Click the Search icon from the Inbox page
Search for text you know exists in a thread by searching for type:chat "", replacing with your search value
Click on the result in the search page
Click on the top chat in the thread to try and navigate to that thread in your inbox
Click on the back icon
The modal closes, but you're supposed to be navigated to a previous page

Screen.Recording.2025-03-20.at.14.17.58.mov

thelullabyy · 2025-03-24T09:44:35Z

@eVoloshchak I see this code has been implemented before and it will dissmis modal with report in RHP. Is this the current expectation?

App/src/pages/home/ReportScreen.tsx

Lines 314 to 318 in 4750e38

    
           const onBackButtonPress = useCallback(() => { 
        
               if (isInNarrowPaneModal) { 
        
                   Navigation.dismissModal(); 
        
                   return; 
        
               }

eVoloshchak · 2025-03-25T16:08:33Z

@thelullabyy, it should dismiss the modal if there is no page to go back to
The behavior should be the same as when clicking on a profile page (video in #58628 (comment))

thelullabyy · 2025-03-26T11:17:06Z

@eVoloshchak I updated PR to fix above bug. Please help to check. This is result :

Screen.Recording.2025-03-26.at.17.mp4

eVoloshchak

The navigation back looks good!
Could you also take a look at #58255 (comment)?
The behavior when clicking on a thread message and clicking on a thread title/icon should be identical, could you use this updated handler for both ReportActionItemParentAction.tsx and ThreadDivider.tsx?

thelullabyy · 2025-03-27T08:46:39Z

@eVoloshchak I updated PR to make the behavior when clicking on thread title/icon same as clicking on thread message. This is the demo, i tested on other platforms and it works well.

Screen.Recording.2025-03-27.at.15.20.50.mov

eVoloshchak · 2025-03-30T19:54:24Z


    const onBackButtonPress = useCallback(() => {
-        if (isInNarrowPaneModal) {
+        const backTo = route?.params?.backTo as string;


Suggested change

const backTo = route?.params?.backTo as string;

const backTo = route?.params?.backTo;

We can move this to an upper scope (below didSubscribeToReportLeavingEvents) so we don't create this every time onBackButtonPress is called

eVoloshchak · 2025-03-30T19:56:53Z

@@ -47,6 +50,16 @@ function ThreadDivider({ancestor, isLinkDisabled = false}: ThreadDividerProps) {
                <PressableWithoutFeedback
                    onPress={() => {


This function and the function in

App/src/pages/home/report/ReportActionItemParentAction.tsx

Line 138 in aa396db

const isVisibleAction = shouldReportActionBeVisible(ancestor.reportAction, ancestor.reportAction.reportActionID, canUserPerformWriteAction);

are identical. Can we move this logic into a single function that is used by both files?

Checklist item

I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

I updated. pls help to check @eVoloshchak

thelullabyy · 2025-04-03T10:01:25Z

@eVoloshchak I updated PR. Please help to check if there is any problem. Thank you.

eVoloshchak · 2025-04-03T10:03:31Z

Perfect timing, just finished testing this and uploaded the last screen recording 😃

eVoloshchak

LGTM!

Beamanator

One NAB, but overall looking great!

Beamanator · 2025-04-07T11:26:09Z

 }

+function navigateToLinkedReportAction(ancestor: Ancestor, isInNarrowPaneModal: boolean, canUserPerformWrite: boolean | undefined, isOffline: boolean) {
+    const isVisibleAction = shouldReportActionBeVisible(ancestor.reportAction, ancestor.reportAction.reportActionID, canUserPerformWrite);


NAB - I'd prefer defining this below the if (isInNarrowPaneModal) { condition since that condition doesn't use this variable - what do you think @eVoloshchak ? Do we have a style guide saying we should declare most vars at the top of the function?

@Beamanator I agree with you and updated below. Thanks.

Beamanator

LGTM! Thanks!

OSBotify · 2025-04-08T09:01:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-09T04:40:09Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.1.25-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-10T00:55:58Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.25-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

thelullabyy added 2 commits March 18, 2025 18:16

fix: not navigate to chat from thread selecting

bd9f3b8

refactor

fc872d8

thelullabyy marked this pull request as ready for review March 18, 2025 11:48

thelullabyy requested a review from a team as a code owner March 18, 2025 11:48

melvin-bot Bot requested review from eVoloshchak and removed request for a team March 18, 2025 11:48

eVoloshchak suggested changes Mar 19, 2025

View reviewed changes

thelullabyy added 3 commits March 26, 2025 17:07

fix: back to wrong page when open from thread

f13ac9c

Merge branch 'main' into fix/58255-not-navigate-to-chat-from-search

afd3320

resolve ESlint

4353f29

eVoloshchak suggested changes Mar 26, 2025

View reviewed changes

fix: add action of thread icon same as thread message

aa396db

eVoloshchak suggested changes Mar 30, 2025

View reviewed changes

thelullabyy added 4 commits March 31, 2025 16:40

refactor code

dfc40be

Merge branch 'main' into fix/58255-not-navigate-to-chat-from-search

9f1eb10

fix ESLint

c054c46

fix ESLint

743e557

eVoloshchak approved these changes Apr 3, 2025

View reviewed changes

melvin-bot Bot requested a review from Beamanator April 3, 2025 10:04

Beamanator previously approved these changes Apr 7, 2025

View reviewed changes

refactor code

58966e9

thelullabyy dismissed Beamanator’s stale review via 58966e9 April 8, 2025 07:25

Beamanator approved these changes Apr 8, 2025

View reviewed changes

Beamanator merged commit ad68890 into Expensify:main Apr 8, 2025

github-actions Bot mentioned this pull request Apr 9, 2025

Deploy Checklist: New Expensify 2025-04-09 #59866

Closed

66 tasks

melvin-bot Bot mentioned this pull request Apr 10, 2025

[Due for payment 2025-04-17] [$500][HIGH] Navigating to a thread from the Search page doesn’t take you to the chat #58255

Closed

8 tasks

huult mentioned this pull request May 14, 2025

[Due for payment 2025-06-09] [$250] Search-Navigation back from the chat details page in Search leads to the "It's not here" page #61124

Closed

8 tasks

	const backTo = route?.params?.backTo as string;
	const backTo = route?.params?.backTo;

		@@ -47,6 +50,16 @@ function ThreadDivider({ancestor, isLinkDisabled = false}: ThreadDividerProps) {
		<PressableWithoutFeedback
		onPress={() => {

Uh oh!

Conversation

thelullabyy commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 18, 2025

Uh oh!

eVoloshchak commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Mar 20, 2025

Uh oh!

eVoloshchak commented Mar 20, 2025

Uh oh!

thelullabyy commented Mar 24, 2025

Uh oh!

eVoloshchak commented Mar 25, 2025

Uh oh!

thelullabyy commented Mar 26, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Mar 27, 2025

Uh oh!

eVoloshchak Mar 30, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Mar 30, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Apr 3, 2025

Uh oh!

eVoloshchak commented Apr 3, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thelullabyy commented Mar 18, 2025 •

edited

Loading

eVoloshchak commented Mar 19, 2025 •

edited

Loading