[Due for payment 2025-06-09] [$250] Search-Navigation back from the chat details page in Search leads to the "It's not here" page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.33.2, 9.1.37.2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6006505
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.4.1 Safari, MacBook Air 15.4 Chrome
App Component: Other

Action Performed:

1. Navigate to the staging.new.expensify and sign in
2. Create a thread for a message in 1:1 chat, send some messages
3. Navigate to the Reports tab
4. Type "type:chat [word in thread]" in the search field
5. Click on the threaded message next to “In” in the message preview
6. On the tread details page click on the threaded message under “Thread” to open chat details
7. Click on the app back button

Expected Result:

The app navigates back to the thread details page in the Reports/Search tab

Actual Result:

"It's not here" page opens when navigating back from the chat details page in the Reports/Search tab

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6817096_1745968726694.Not_here.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922415692533867910
• Upwork Job ID: 1922415692533867910
• Last Price Increase: 2025-05-13
• Automatic offers:
• daledah | Contributor | 107305379

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"It's not here" page opens when navigating back from the chat details page in the Reports/Search tab

What is the root cause of that problem?

When clicking thread parent message on step 6, we call navigateToLinkedReportAction

App/src/pages/home/report/ReportActionItemParentAction.tsx

Lines 138 to 142 in a684416

	onPress={
	canCurrentUserOpenReport(ancestorReports.current?.[ancestor?.report?.reportID])
	? () => navigateToLinkedReportAction(ancestor, isInNarrowPaneModal, canUserPerformWriteAction, isOffline)
	: undefined
	}

And since we're in search page (report is displayed in RHP), we navigate with backTo param set as SCREENS.SEARCH.REPORT_RHP

App/src/libs/ReportUtils.ts

Lines 8403 to 8412 in a684416

	if (isInNarrowPaneModal) {
	Navigation.navigate(
	ROUTES.SEARCH_REPORT.getRoute({
	reportID: ancestor.report.reportID,
	reportActionID: ancestor.reportAction.reportActionID,
	backTo: SCREENS.SEARCH.REPORT_RHP,
	}),
	);
	return;
	}

And then in ReportScreen, this logic is implemented incorrectly:

App/src/pages/home/ReportScreen.tsx

Lines 328 to 336 in a684416

	const onBackButtonPress = useCallback(() => {
	if (isInNarrowPaneModal && backTo !== SCREENS.SEARCH.REPORT_RHP) {
	Navigation.dismissModal();
	return;
	}
	if (backTo) {
	Navigation.goBack(backTo as Route, {shouldPopToTop: true});
	return;
	}

The first condition should handle case when backTo is SCREENS.SEARCH.REPORT_RHP, in this case we should dismissModal, but we used inequality operator, so the second if logic is called instead, lead to not found page, because SCREENS.SEARCH.REPORT_RHP is not an existing route.

What changes do you think we should make in order to solve the problem?

We should use equality here

App/src/pages/home/ReportScreen.tsx

Lines 329 to 332 in a684416

	if (isInNarrowPaneModal && backTo !== SCREENS.SEARCH.REPORT_RHP) {
	Navigation.dismissModal();
	return;
	}

This will dismissModal when clicking back button.

If we want to go back to thread instead, make changes to backTo here

App/src/libs/ReportUtils.ts

Line 8408 in a684416

backTo: SCREENS.SEARCH.REPORT_RHP,

backTo: Navigation.getActiveRoute(),

And remove this part since it's irrelevant now

App/src/pages/home/ReportScreen.tsx

Lines 329 to 332 in a684416

	if (isInNarrowPaneModal && backTo !== SCREENS.SEARCH.REPORT_RHP) {
	Navigation.dismissModal();
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@JmillsExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@JmillsExpensify 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021922415692533867910

[JmillsExpensify]

Opened this up to the community.