Fix headlines to be serif instead of mono fonts#54922
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@deetergp @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://b140fdff.helpdot.pages.dev ⚡️ |
Reviewer Checklist
Screenshots/Videos
|
|
@srikarparsi @isabelastisser One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @shubham1206agra, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #54929. |
| @@ -131,7 +131,7 @@ details[open] > summary { | |||
|
|
|||
| h1, | |||
| summary { | |||
There was a problem hiding this comment.
Interesting, what exactly is a summary though? Perhaps summary is what is being used for code blocks, and thus we should actually separate out these styles?
There was a problem hiding this comment.
Nope. It is not code-related.
There was a problem hiding this comment.
Okay cool, you can ignore me then :)
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.83-0 🚀
|
|
@shawnborton @srikarparsi @deetergp Anything required to QA here? |
|
All good, I checked the help site and it looks like everything is working as expected now. |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 🚀
|


Explanation of Change
Changes headlines from Expensify Mono font back to Expensify New Kansas
Fixed Issues
$ #54773 (comment)
PROPOSAL:
Tests
Expensify New KansasfontOffline tests
QA Steps
See tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop