Add Expensify Mono font and update code styling by MobileMage · Pull Request #54773 · Expensify/App

MobileMage · 2025-01-02T23:39:28Z

Explanation of Change

Fixed Issues

$ #54227
PROPOSAL: #54227 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-02T23:39:38Z

melvin-bot · 2025-01-02T23:39:40Z

@shubham1206agra @slafortune One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-01-03T06:43:07Z

I feel like the fallback fonts should be mono fonts and not helvetica, etc?

Ah, yes I'll make that change.

shubham1206agra · 2025-01-04T03:38:23Z

@JoshIri360 The commits must have verified signatures. Please fix this.

- Introduced 'Expensify Mono' font with regular and bold weights in _fonts.scss. - Updated _main.scss to apply 'Expensify Mono' font to code elements with custom styling. - Added new font files: ExpensifyMono-Regular.woff, ExpensifyMono-Regular.woff2, ExpensifyMono-Bold.woff, and ExpensifyMono-Bold.woff2.

MobileMage · 2025-01-04T11:44:40Z

@JoshIri360 The commits must have verified signatures. Please fix this.

@shubham1206agra I've fixed this now

shubham1206agra · 2025-01-05T08:20:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

dubielzyk-expensify · 2025-01-06T04:26:32Z

Is this bug where it's using the light mode logo in dark mode part of this PR?

MobileMage · 2025-01-06T04:48:50Z

Is this bug where it's using the light mode logo in dark mode part of this PR?

@dubielzyk-expensify This PR is focused on font-related changes (adding Expensify Mono font and updating typography styles). The light/dark mode logo issue appears to be unrelated, but the logo used in my screenshot is different from the dark one shown here, so this may be fixed.

dubielzyk-expensify · 2025-01-07T00:29:26Z

Cool. Otherwise I think this looks good, but @Expensify/design for last gut check.

shawnborton · 2025-01-07T09:19:12Z

Yup, this works for me - LGTM.

marcochavezf

Code LGTM, thanks!

dubielzyk-expensify · 2025-01-07T23:26:54Z

This has cased an error so we wanna revert this PR. The headlines are now ExpensifyMono which we don't want:

I saw it in the screenshot above, but assume it was for testing. We don't want ExpensifyMono on the headlines. I dunno if it's easier to revert the PR or if it's easier to just submit a fix

dubielzyk-expensify · 2025-01-07T23:31:30Z

Actually. I'll just submit a bug fix for this 👍

github-actions · 2025-01-08T03:00:23Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-08T03:40:12Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

shawnborton · 2025-01-08T09:21:34Z

 h1,
 summary {
-    font-family: 'Expensify New Kansas', 'Helvetica Neue', 'Helvetica', Arial, sans-serif;
+    font-family: 'Expensify Mono', 'SFMono-Regular', monospace, Arial, sans-serif;


@JoshIri360 why did we update the h1 styles to use mono?

Also, how is the summary tag used across the site? What does it do exactly?

Think this was answered in the other PR, but this is all fixed now :)

MobileMage · 2025-01-09T04:45:55Z

@JoshIri360 why did we update the h1 styles to use mono?

Also, how is the summary tag used across the site? What does it do exactly?

Looks like a mistake on my end, this shouldn’t be Mono font as it wasn’t in my proposal.

It looks like it’s been fixed already in another PR, but let me know if I need to do anything else.

I’ll make sure to double check moving forward, sorry about that.

dubielzyk-expensify · 2025-01-09T05:07:45Z

No all good. I spotted it in the review, but assumed it was testing when I should've raised it, so equally on my end 😄 No biggie 👍

github-actions · 2025-01-10T03:38:48Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

MobileMage requested review from a team as code owners January 2, 2025 23:39

melvin-bot Bot requested review from shubham1206agra and slafortune January 2, 2025 23:39

melvin-bot Bot removed the request for review from a team January 2, 2025 23:39

MobileMage mentioned this pull request Jan 2, 2025

[HOLD for payment 2025-01-17] [$250] Code formatting in Help Site needs improvement #54227

Closed

8 tasks

shawnborton reviewed Jan 3, 2025

View reviewed changes

Comment thread docs/_sass/_main.scss Outdated

MobileMage force-pushed the fix-docs-code-format branch from d306829 to d592c1b Compare January 4, 2025 11:17

Add correct fallback fonts

34d31ff

shubham1206agra approved these changes Jan 5, 2025

View reviewed changes

melvin-bot Bot requested a review from marcochavezf January 5, 2025 08:22

marcochavezf approved these changes Jan 7, 2025

View reviewed changes

marcochavezf merged commit 2dedba9 into Expensify:main Jan 7, 2025

dubielzyk-expensify mentioned this pull request Jan 8, 2025

Fix headlines to be serif instead of mono fonts #54922

Merged

50 tasks

github-actions Bot mentioned this pull request Jan 8, 2025

Deploy Checklist: New Expensify 2025-01-08 #54928

Closed

60 tasks

shawnborton reviewed Jan 8, 2025

View reviewed changes

Uh oh!

Conversation

MobileMage commented Jan 2, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 2, 2025

Concierge reviewer checklist:

Uh oh!

melvin-bot Bot commented Jan 2, 2025

Uh oh!

shawnborton Jan 3, 2025

Choose a reason for hiding this comment

Uh oh!

MobileMage Jan 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shubham1206agra commented Jan 4, 2025

Uh oh!

MobileMage commented Jan 4, 2025

Uh oh!

shubham1206agra commented Jan 5, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dubielzyk-expensify commented Jan 6, 2025

Uh oh!

MobileMage commented Jan 6, 2025

Uh oh!

dubielzyk-expensify commented Jan 7, 2025

Uh oh!

shawnborton commented Jan 7, 2025

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Jan 7, 2025

Uh oh!

github-actions Bot commented Jan 8, 2025

Uh oh!

github-actions Bot commented Jan 8, 2025

Uh oh!

shawnborton Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

MobileMage commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dubielzyk-expensify commented Jan 7, 2025 •

edited

Loading

MobileMage commented Jan 9, 2025 •

edited

Loading