Align default IDs in IOU.ts file by VickyStash · Pull Request #54534 · Expensify/App

VickyStash · 2024-12-24T16:23:10Z

Explanation of Change

Align default IDs in IOU.ts file

Fixed Issues

$ #50360
PROPOSAL: #50360 (comment)

Tests

Verify that no errors appear in the JS console

1. Create expense:

Test Create expense functionality from FAB (Manual, Scan, Distance)
Test Submit expense functionality in 1-1 chat (Manual, Scan). Pay the submitted expense as another user.
Test Submit expense functionality in workspace chat (Manual, Scan, Distance)
Test expense update/removal.
Open any expense and put it on hold, undo it.

2. Send Invoice: *Ensure the Invoice feature is turned on at least in one workspace.

Test Send invoice from FAB.
Test Send invoice from workspace chat.

3. Split expense

Test Split expense flow in the 1-1 DM chat.
Test Split expense flow in the workspace chat.

4. Track expense

Test Track expense flow in the Self DM chat.
Test Track expense flow in the workspace chat.

5. Pay user

In the workspace chat test Pay user flow.

Offline tests

Same, as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

android_web_2.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

…numeric ids

…e distance request

# Conflicts: # .eslintrc.changed.js

…ve unnecessary default ids

# Conflicts: # src/libs/actions/IOU.ts

# Conflicts: # src/libs/ReportUtils.ts # src/libs/actions/IOU.ts

VickyStash · 2025-01-16T10:47:41Z

@paultsimura kind bump 🙂

paultsimura · 2025-01-16T12:19:09Z

Sorry, I missed this.
Please don't forget to click "re-request review" when it's ready for another look:

paultsimura · 2025-01-16T16:50:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-01-16.at.17.41.11.mov

MacOS: Desktop

paultsimura

LGTM ✔️
Tested carefully, but this is probably the most invasive PR as it touches IOU 😟

VickyStash · 2025-01-17T08:11:40Z

@neil-marcellini maybe we can ask QA team for regression testing of this PR before merging, since it touches key functionality of the app?

paultsimura · 2025-01-17T08:17:50Z

@neil-marcellini maybe we can ask QA team for regression testing of this PR before merging, since it touches key functionality of the app?

I think we'll have QA when this PR hits staging anyway 🤔

neil-marcellini

Wow, this is a lot of work. Mostly looks great. I have a few requests and several NAB comments.

VickyStash · 2025-01-21T15:05:17Z

I'm going to be OOO Jan 22 - 26 ❄️

# Conflicts: # .eslintrc.changed.js # src/libs/actions/IOU.ts

OSBotify · 2025-01-21T20:29:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:27:14Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

IuliiaHerets · 2025-01-23T21:28:14Z

This PR is failing because of issue #55673

github-actions · 2025-01-28T01:50:39Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

adhorodyski and others added 27 commits December 19, 2024 10:19

chore: test commit for the linter

2cd62ce

chore: fix lint errors on missing CONST.DEFAULT_NUMBER_ID usages for …

2f53a1a

…numeric ids

chore: rm a dummy console log

9f0352f

chore: remove an eslint override for the IOU.ts file exclusion

dd0de46

chore: add an early return for transactionThreadReportIDs of undefined

661790f

chore: add an early return on invalid input to the payInvoice function

1ddfa90

chore: filter out undefiend values

529b1f6

chore: allow undefined output from getIOURequestPolicyID

17829b7

chore: remove a fallback index access on the failure data

cf617bd

chore: early return on missing input to the cancelPayment func

1b42796

chore: remove more onyx key fallbacks

2042569

Merge branch 'Expensify:main' into chore/eslint-consistent-id-iou

c98da87

chore: optionally push to the optimistic data

d268002

chore: wrap a success data push in an if statement for undefined input

93d2cbd

chore: wrap a failure data push in an if statement for undefined input

2c83daa

chore: wrap L1831 failure data push

135baa7

chore: early return on missing splitData.createdReportActionID for th…

0ab1de1

…e distance request

chore: pass in undefined with a missing childReportID

46e8c8e

chore: extract an optimisticData push to ensure a param

390df26

chore: use string or undefined as a value

cdccb13

chore: call 2 new optimistic updates only on conditions met

de2c69b

Merge branch 'refs/heads/main' into chore/eslint-consistent-id-iou

2ece26c

# Conflicts: # .eslintrc.changed.js

Update getLastVisibleAction and getLastVisibleMessage functions. Remo…

2332beb

…ve unnecessary default ids

Remove '-1' id from object keys

871a257

Fix test

80901b5

Merge branch 'refs/heads/main' into chore/eslint-consistent-id-iou

617f8b0

# Conflicts: # src/libs/actions/IOU.ts

Fix params related lint errors

0caab12

VickyStash added 2 commits December 30, 2024 15:38

Merge branch 'refs/heads/main' into chore/eslint-consistent-id-iou

ac221d1

# Conflicts: # src/libs/ReportUtils.ts # src/libs/actions/IOU.ts

Lint fix

bf73430

VickyStash added 2 commits January 16, 2025 11:04

Lint fixes

d23067e

Minor lint fix

8ddbf17

VickyStash requested a review from paultsimura January 16, 2025 12:20

paultsimura approved these changes Jan 16, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini January 16, 2025 16:55

neil-marcellini requested changes Jan 17, 2025

View reviewed changes

VickyStash added 4 commits January 20, 2025 09:19

Merge branch 'refs/heads/main' into chore/eslint-consistent-id-iou

7471970

Apply reviewer feedback, fix errors after merging main

7d8cc98

Minor code improvements

1dbedd9

Don't merge empty object to onyx

a91d701

neil-marcellini previously approved these changes Jan 21, 2025

View reviewed changes

VickyStash added 2 commits January 21, 2025 20:18

Merge branch 'refs/heads/main' into chore/eslint-consistent-id-iou

afaa92e

# Conflicts: # .eslintrc.changed.js # src/libs/actions/IOU.ts

Fix lint errors

4d75438

VickyStash dismissed neil-marcellini’s stale review via 4d75438 January 21, 2025 19:56

neil-marcellini approved these changes Jan 21, 2025

View reviewed changes

neil-marcellini merged commit f40c622 into Expensify:main Jan 21, 2025

github-actions Bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

IuliiaHerets mentioned this pull request Jan 23, 2025

Workspace chat - There is no Track expense option in the workspace chat. #55673

Closed

8 tasks

mitarachim mentioned this pull request Jan 24, 2025

Create expense-Error appears in console when creating a Scan expense #55733

Closed

8 tasks

ChavdaSachin mentioned this pull request Jan 30, 2025

[$250] Refactor shareTrackedExpense to use a parameter object #54466

Closed

Conversation

VickyStash commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash commented Jan 16, 2025

Uh oh!

paultsimura commented Jan 16, 2025

Uh oh!

paultsimura commented Jan 16, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Jan 17, 2025

Uh oh!

paultsimura commented Jan 17, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash commented Jan 21, 2025

Uh oh!

OSBotify commented Jan 21, 2025

Uh oh!

github-actions Bot commented Jan 23, 2025

Uh oh!

IuliiaHerets commented Jan 23, 2025

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

VickyStash commented Dec 24, 2024 •

edited

Loading

paultsimura left a comment •

edited

Loading