fix: Attachment - Press enter fullscreen mode in video player by Tab

[nkdengineer]

Details

Fixed Issues

$ #44379
PROPOSAL: #44379 (comment)

Tests

1. Open the app
2. Go to any conversation
3. Click "+" and choose Add Attachment
4. Choose any available video
5. Press the Tab on the video player to fullscreen
6. Press enter
7. Verify that: Only the video player is fullscreen; the app keeps its original size
   Note: It won't work on native Android because here

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Open the app
2. Go to any conversation
3. Click "+" and choose Add Attachment
4. Choose any available video
5. Press the Tab on the video player to fullscreen
6. Press enter
7. Verify that: Only the video player is fullscreen; the app keeps its original size
   Note: It won't work on native Android because here

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[melvin-bot]

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[getusha]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Not applicable

Android: mWeb Chrome

Screen.Recording.2024-07-16.at.1.40.14.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-07-16.at.1.18.11.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-07-16.at.1.22.56.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-16.at.1.16.31.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-07-16.at.1.13.47.in.the.afternoon.mov

[getusha]

@nkdengineer i can reproduce this on android native

Screen.Recording.2024-07-16.at.1.37.42.in.the.afternoon.mov

[getusha]

friendly bump @nkdengineer

[nkdengineer]

Checking this now.

[nkdengineer]

@getusha Sorry for the delay
I have some problems with building android
I don't think it's a bug here
On native, when you press enter it means you press the send button

[getusha]

On native, when you press enter it means you press the send button

Isn't that the beahvior on every platform? when there is another element focused it shouldn't send.

[nkdengineer]

I'll update today

[nkdengineer]

Still investigating to find the reason

[nkdengineer]

@getusha It's a weird behavior in Android simulator that we can use the tab key to focus on an element. On native, we cannot detect the focus element here, and then onPress can be triggered because shouldDisableEnterShortcut is false here.

We can't reproduce this in the real device so I don't think it's a bug.

[nkdengineer]

@getusha Friendly bump.

[getusha]

@nkdengineer could you add a note on the PR description stating this doesn't apply for Android native?

[nkdengineer]

@getusha i updated

[MonilBhavsar]

So, is this issue/limitation only on android simulator, and not on real device? Did we confirm it?

[nkdengineer]

@MonilBhavsar Yes, the we don't have the tab key in the real device. To ensure can you run an adhoc build then I can test again in the real device.

[MonilBhavsar]

Thanks for clarifying. That's a good idea. Let's test it.

[nkdengineer]

Will check tomorrow

[nkdengineer]

Still investigating

[nkdengineer]

@MonilBhavsar After testing for many places in the App, the Android bug happens in all Modal components, other components don't face this bug. See the video here the cancel button is focused but the event of the delete button is triggered when we press on enter key. I can't find the RCA as to why this only happens in the Modal component.

Screen.Recording.2024-10-07.at.17.29.11.mov

[nkdengineer]

@MonilBhavsar Any thoughts on this?

[MonilBhavsar]

See the video here the cancel button is focused but the event of the delete button is triggered when we press on enter key.

That's the correct expected behavior, no?

[nkdengineer]

@MonilBhavsar That's not expected behavior let's see the behavior on the web. It's an Android app bug in Modal component.

Screen.Recording.2024-10-14.at.16.40.04.mov

[MonilBhavsar]

Could you please describe the bug. I am not getting it, sorry.
I think if button is focussed and enter is pressed, we should trigger the event

[nkdengineer]

@MonilBhavsar The problem with the example video above is the cancel button is focused which should close the modal if we press the enter key. But actually, the delete button event is still triggered. It only happens on Android native and works well on other platforms.

[MonilBhavsar]

Ah, I see. Thanks for explaining. Not easy to figure out from video 😅
Does this happen on main and for all modals? To be honest, this sounds very similar to the issue we're actually fixing

[nkdengineer]

Does this happen on main and for all modals?

@MonilBhavsar Yes, it happens on the main. Currently, the bug that we're fixing in this PR is resolved except for the Android native. But it's an Android bug that happens in other places on the latest main of the App with different RCA. So I think we should ignore this here.

[MonilBhavsar]

But it's an Android bug that happens in other places on the latest main of the App with different RCA. So I think we should ignore this here.

Okay and that does happen when using external hardware keyboard on android device. Is that right?

[nkdengineer]

Okay and that does happen when using external hardware keyboard on android device. Is that right?

@MonilBhavsar Yes that happens when we use the tab key with external keyboard.

[MonilBhavsar]

Okay cool! I think very less people would actually use external keyboard with android device and since it happens on all modals, it's fine to descope it cc @getusha

[getusha]

It would have been great to fix this on Android, since we're trying to address the same issue on other platforms.

[melvin-bot]

@MonilBhavsar looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[MonilBhavsar]

All tests were passing

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅