[HOLD for payment 2024-11-01] [$250] Attachment - Press enter fullscreen mode in video player by Tab, app go to fullscreen

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): crowdtest.expensify+test002@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app
2. Go to any conversation
3. Click "+" and choose Add Attachment
4. Choose any available video
5. Press the Tab on the video player to fullscreen
6. Press enter

Expected Result:

Only the video player is fullscreen; the app keeps its original size. Same as what happens when using a cursor:

• Upload a video to a chat as an attachment
• Click fullscreen
• Notice the video expands to fullscreen
• Press Enter and the video uploads into the chat as expected

Actual Result:

You will see after clicking the fullscreen button in the video player by pressing enter at the index position. Then the application will be fullscreen instead of video player.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6523729_1719300111673.Screen_Recording_2024-06-25_at_14.07.26.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d24e62428813c96d
• Upwork Job ID: 1806399701650517149
• Last Price Increase: 2024-07-04
• Automatic offers:
• nkdengineer | Contributor | 103091438

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[Christinadobrzyn]

Ah that is a good catch. I'm not actually sure if we want to change anything though - asking the team for some guidance. https://expensify.slack.com/archives/C066HJM2CAZ/p1719340979142479

[Christinadobrzyn]

nudged the team for a review on expected behaviour

[Christinadobrzyn]

no response from the team. I think it's safe to assume we want the behaviour to be the same as when using a cursor:

• Upload a video to a chat as an attachment
• Click fullscreen
• Notice the video expands to fullscreen
• Press Enter and the video uploads as expected

I think this can be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d24e62428813c96d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)