fix: LHN of self-DM still shows actionable whisper after submitted by dominictb · Pull Request #44684 · Expensify/App

dominictb · 2024-07-01T15:17:22Z

Details

Fixed Issues

$ #44217
PROPOSAL: #44217 (comment)

Tests

Verify that no errors appear in the JS console

On self-DM click '+' > Track Expense
On the actionable whisper options click on 'Submit it to someone'
Choose another user and Submit
The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM no longer shows "What would you like to do with this expense?"

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-01.at.22.11.42.mov

Android: mWeb Chrome

Screen.Recording.2024-07-01.at.22.13.12.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-07-01.at.22.16.46.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-01.at.22.08.41.mov

MacOS: Desktop

Screen.Recording.2024-07-01.at.22.08.41.mov

melvin-bot · 2024-07-01T15:17:26Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-07-07T16:46:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-07.at.10.02.22.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-07.at.10.00.53.PM.mov

iOS: Native

Screen.Recording.2024-07-07.at.9.57.23.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-07.at.9.56.42.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-07.at.9.51.16.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-07.at.9.52.55.PM.mov

allroundexperts

Works great!

dominictb · 2024-07-15T15:03:30Z

@aldo-expensify Pls help review this PR

aldo-expensify · 2024-07-15T19:45:59Z

Sorry for the delay, I was OOO

OSBotify · 2024-07-15T19:55:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:04:44Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:13:28Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:19:40Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:50:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jayeshmangwani · 2024-07-24T18:36:24Z

 function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
-    const resolution = reportAction && 'resolution' in reportAction ? reportAction?.resolution : null;
+    const originalMessage = getOriginalMessage(reportAction);
+    const resolution = originalMessage && 'resolution' in originalMessage ? originalMessage?.resolution : null;


Before accessing the 'resolution' in originalMessage, we should have checked the typeof originalMessage, and if it's an object, then we should have accessed the 'resolution'. Directly accessing the 'resolution' causes this crash when we get the system message for exporting to CSV.

fix: LHN of self-DM still shows actionable whisper after submitted

49272b0

dominictb requested a review from a team as a code owner July 1, 2024 15:17

melvin-bot Bot removed the request for review from a team July 1, 2024 15:17

melvin-bot Bot requested a review from allroundexperts July 1, 2024 15:17

dominictb mentioned this pull request Jul 1, 2024

[HOLD for payment 2024-07-24] [$250] Track expense - LHN of self-DM still shows actionable whisper after submitted to someone #44217

Closed

6 tasks

fix: minor change in logic

120fbd3

allroundexperts approved these changes Jul 7, 2024

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify July 7, 2024 17:08

dominictb mentioned this pull request Jul 13, 2024

fix: restore report lastMessageText after resolve whisper msg #44764

Merged

50 tasks

aldo-expensify approved these changes Jul 15, 2024

View reviewed changes

aldo-expensify merged commit f9b148c into Expensify:main Jul 15, 2024

github-actions Bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

jayeshmangwani reviewed Jul 24, 2024

View reviewed changes

jayeshmangwani mentioned this pull request Jul 24, 2024

[PAID] [$250] Expense report - App crashes after exporting expense report to CSV in OD #45457

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: LHN of self-DM still shows actionable whisper after submitted#44684

fix: LHN of self-DM still shows actionable whisper after submitted#44684
aldo-expensify merged 2 commits into
Expensify:mainfrom
dominictb:fix/44217

dominictb commented Jul 1, 2024

Uh oh!

melvin-bot Bot commented Jul 1, 2024

Uh oh!

allroundexperts commented Jul 7, 2024 •

edited

Loading

Uh oh!

allroundexperts left a comment

Uh oh!

dominictb commented Jul 15, 2024

Uh oh!

aldo-expensify commented Jul 15, 2024 •

edited

Loading

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

jayeshmangwani Jul 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

dominictb commented Jul 1, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 1, 2024

Uh oh!

allroundexperts commented Jul 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jul 15, 2024

Uh oh!

aldo-expensify commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

jayeshmangwani Jul 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

allroundexperts commented Jul 7, 2024 •

edited

Loading

aldo-expensify commented Jul 15, 2024 •

edited

Loading