[HOLD for payment 2024-07-24] [$250] Track expense - LHN of self-DM still shows actionable whisper after submitted to someone

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2990401
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: on self-DM click '+' > Track Expense

1. On the actionable whisper options click on 'Submit it to someone'
2. Choose another user and Submit

Expected Result:

The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM no longer shows "What would you like to do with this expense?"

Actual Result:

The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM still shows "What would you like to do with this expense?"

Workaround:

Unnkown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521590_1719068458775.LHN_preview.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01112f075346c9b0f8
• Upwork Job ID: 1805265765671190738
• Last Price Increase: 2024-06-24
• Automatic offers:
• dominictb | Contributor | 102920804

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The transaction is moved to that new chat.
Tracked expense is not displayed in the self DM anymore.
LHN of self-DM still shows "What would you like to do with this expense?"

What is the root cause of that problem?

• Our function isResolvedActionTrackExpense:
  

  App/src/libs/ReportActionsUtils.ts

  Lines 672 to 675 in 4dc1710

  	function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
  	const resolution = reportAction && 'resolution' in reportAction ? reportAction?.resolution : null;
  	return isActionableTrackExpense(reportAction) && !!resolution;
  	}

  does not work properly because there is no reportAction?.resolution.

• That leads to this logic is wrong:
  

  App/src/libs/OptionsListUtils.ts

  Line 313 in 4dc1710

  !ReportActionUtils.isResolvedActionTrackExpense(reportAction),

What changes do you think we should make in order to solve the problem?

• We need to update:
  

  App/src/libs/ReportActionsUtils.ts

  Lines 672 to 675 in 4dc1710

  	function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
  	const resolution = reportAction && 'resolution' in reportAction ? reportAction?.resolution : null;
  	return isActionableTrackExpense(reportAction) && !!resolution;
  	}

  
  to:

function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
    const originalMessage = getOriginalMessage(reportAction);
    const resolution = originalMessage?.resolution ?? null;
    return isActionableTrackExpense(reportAction) && !!resolution;
}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01112f075346c9b0f8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@slafortune, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!