-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Bump eslint-config-expensify version in E/App #36849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
roryabraham
merged 36 commits into
Expensify:main
from
software-mansion-labs:chore/bump-eslint-config
Feb 27, 2024
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
40366b7
Bump eslint and temporarly turn off new rules
blazejkustra 0631318
Fix eslint running on files in a build catalog
blazejkustra 3cc326e
Fix no-loss-of-precision
blazejkustra b105c6c
Fix no-promise-executor-return
blazejkustra 472878f
Turn off no-import-assign rule in tests
blazejkustra 9c54cb9
Fix no-unsafe-optional-chaining
blazejkustra 5519dba
Fix react/jsx-no-useless-fragment
blazejkustra 6f53d0d
Remove eslint-plugin-react-hooks
blazejkustra b7f3554
Turn off prefer-regex-literals
blazejkustra 67aadf2
fix import/no-relative-packages and add desktop import path
blazejkustra 6cc0b0e
Fix react/no-unused-class-component-methods
blazejkustra 5b249d2
Disable import/no-import-module-exports in one file
blazejkustra 3e5295f
Fix default-param-last
blazejkustra d6919aa
Fix sort-comp
blazejkustra 9aadd40
Disable default-param-last
blazejkustra 8375325
Fix react/no-unstable-nested-components
blazejkustra f954f5e
Add @desktop to webpack.common.js
blazejkustra bbb4f41
Fix webpack config
blazejkustra 6389069
Adjust after initial review
blazejkustra 0439c4e
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 5469b96
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 6f77a7d
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 5c4c711
Add eslint disable comment
blazejkustra 7905a13
Merge branch 'main' into chore/bump-eslint-config
blazejkustra aee2c3f
Fix more no-unsafe-optional-chaining
blazejkustra 871f559
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 259d23b
alphabetize imports
blazejkustra 4ad944b
Extract styles to a separate variable
blazejkustra 9dc38b9
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 9723519
Fix new fragment errors
blazejkustra 1d46123
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 7907c17
Use string literals in favor of string concatenation
blazejkustra 746780f
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 542d1de
Merge branch 'main' into chore/bump-eslint-config
blazejkustra 7264c60
Remove ';' that crashes the app
blazejkustra f691cfd
Merge branch 'main' into chore/bump-eslint-config
blazejkustra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| **/node_modules/* | ||
| **/dist/* | ||
| android/**/build/* | ||
| .github/actions/**/index.js" | ||
| docs/vendor/** | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // eslint-disable-next-line import/no-import-module-exports | ||
| import mockRNLocalize from 'react-native-localize/mock'; | ||
|
|
||
| module.exports = mockRNLocalize; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes
npm run lintbug that I reported two weeks ago here